Remove old platform messaging API #8837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Mar 16, 2017
| /// An command object representing the invocation of a named method. | ||
| class MethodCall { | ||
| final String method; | ||
| final dynamic arguments; |
There was a problem hiding this comment.
Please put constructors first and doc these member variables.
abarth
reviewed
Mar 16, 2017
| } | ||
|
|
||
| @override | ||
| int get hashCode => method.hashCode ^ (arguments?.hashCode ?? 0); |
There was a problem hiding this comment.
also if possible put == and hashCode together so it's obvious that they're equivalent
abarth
reviewed
Mar 16, 2017
| import 'message_codecs.dart'; | ||
|
|
||
| /// A JSON [PlatformMethodChannel] for navigation. | ||
| const PlatformMethodChannel flutterNavigationChannel = const PlatformMethodChannel( |
There was a problem hiding this comment.
This would be a bit cleaner if there was a class that these channels all belonged to as static members. Perhaps:
SystemChannels.navigation
SystemChannels.platform
etc
|
|
Hixie
reviewed
Mar 16, 2017
|
|
||
| @override | ||
| bool operator== (dynamic o) { | ||
| if (o is! MethodCall) |
There was a problem hiding this comment.
this should probably be a runtimeType check so that == isn't sensitive to the order of its arguments
Hixie
reviewed
Mar 16, 2017
| int get hashCode => method.hashCode ^ (arguments?.hashCode ?? 0); | ||
|
|
||
| @override | ||
| String toString() => 'MethodCall($method, $arguments)'; |
There was a problem hiding this comment.
s/MethodCall/$runtimeType/ in case someone subclasses it
mravn-google
added a commit
to flutter/engine
that referenced
this pull request
Mar 17, 2017
Breaking change: removed facilities for JSON and string messaging from FlutterView/FlutterViewController, leaving only binary messaging there. All other use of flutter communication now goes through FlutterMessageChannel and FlutterMethodChannels. Retained use of String and JSON codecs for now. Companion flutter PR: flutter/flutter#8837
mravn-google
force-pushed
the
remove_old_msg_api
branch
from
286e381
to
671bf8e
Compare
brianosman
pushed a commit
to brianosman/engine
that referenced
this pull request
Jun 16, 2017
Breaking change: removed facilities for JSON and string messaging from FlutterView/FlutterViewController, leaving only binary messaging there. All other use of flutter communication now goes through FlutterMessageChannel and FlutterMethodChannels. Retained use of String and JSON codecs for now. Companion flutter PR: flutter/flutter#8837
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: removed deprecated methods of PlatformMessages, leaving only binary messaging there. All other use of platform communication now goes through PlatformMessageChannel and PlatformMethodChannels. Retained use of String and JSON codecs for now.
Companion engine PR: flutter/engine#3482