Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autovalidate deprecations #90292

Merged
merged 4 commits into from
Oct 6, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 17, 2021

This removes the autovalidate parameter from

  • DropdownButtonFormField
  • TextFormField
  • Form
  • FormField

The replacement for which is autovalidateMode. This is supported by dart fix.

These deprecations have expired, as laid out in flutter.dev/go/deprecations-removed-after-2-5

Part of #90287

This affects the date picker and the time picker as well, but just under the hood. They were using restorable autovalidation through the old API.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Sep 17, 2021
@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Sep 17, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Sep 17, 2021
@Piinks
Copy link
Contributor Author

Piinks commented Sep 22, 2021

This one will require a bit more work, it's being used in the time picker so I need to refactor that out.

@flutter-dashboard flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label Sep 30, 2021
@Piinks Piinks changed the title [WIP] Remove autovalidate deprecations Remove autovalidate deprecations Sep 30, 2021
@Piinks
Copy link
Contributor Author

Piinks commented Sep 30, 2021

Currently migrating internal customers.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks
Copy link
Contributor Author

Piinks commented Oct 6, 2021

Customers have been migrated, this can land now.

@fluttergithubbot fluttergithubbot merged commit 72924f1 into flutter:master Oct 6, 2021
Piinks added a commit that referenced this pull request Oct 7, 2021
Piinks added a commit that referenced this pull request Oct 7, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: text input Entering text in a text field or keyboard related problems c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants