-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove autovalidate deprecations #90292
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This one will require a bit more work, it's being used in the time picker so I need to refactor that out. |
Currently migrating internal customers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Customers have been migrated, this can land now. |
This removes the
autovalidate
parameter fromThe replacement for which is
autovalidateMode
. This is supported by dart fix.These deprecations have expired, as laid out in flutter.dev/go/deprecations-removed-after-2-5
Part of #90287
This affects the date picker and the time picker as well, but just under the hood. They were using restorable autovalidation through the old API.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.