-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visual overflow when overscrolling RenderShrinkWrappingViewport #91620
Conversation
Gold has detected about 4 new digest(s) on patchset 1. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But is there a way to visualize the difference in the golden files better even on white background? Maybe add a solid color dart background around everything? I imagine that this will get confusing again when the golden breaks and we need to debug what's different...
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Gold has detected about 2 new digest(s) on patchset 2. |
Fixed the golden files to add more contrast. |
Gold has detected about 1 new digest(s) on patchset 4. |
@Piinks Any progress? |
Fixes #89717 for real this time. :)
#89717 is a regression that was caused by #87143 while resolving #10949
#90419 originally sought to resolve it, but the test cases in that change did not account for every case of visual overflow.
This updates
hasVisualOverflow
so that the clip is properly applied when overscrolling a shrinkwrapping viewport. Seen here in the golden file test I added.Because these images are translucent, the images look the same on github in light mode. Switching to dark mode makes the difference clearer.
Overflowing
Not Overflowing 🎉
There are a lot of tests for each of these changes, and so while I was here I cleaned then up a bit to be more organized.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.