Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake Mac plugin_test_ios #91823

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Deflake Mac plugin_test_ios #91823

merged 1 commit into from
Oct 15, 2021

Conversation

keyonghan
Copy link
Contributor

The Mac plugin_test_ios has been validated in staging for >50 runs, and it also passed >20 runs in prod as bringup:true.

This PR deflakes the test.

#88794

@google-cla google-cla bot added the cla: yes label Oct 14, 2021
jmagman
jmagman approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@keyonghan keyonghan mentioned this pull request Oct 15, 2021
Closed
@fluttergithubbot fluttergithubbot merged commit 11308a8 into flutter:master Oct 15, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@keyonghan @clocksmith
Deflake Mac plugin_test_ios (flutter#91823)
cb17130
@keyonghan keyonghan deleted the deflake_plugin_test_ios branch April 25, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keyonghan @jmagman @CaseyHillers @fluttergithubbot