Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release_dashboard] Add a generic tooltip widget #92187

Merged
merged 2 commits into from
Oct 20, 2021
Merged

[release_dashboard] Add a generic tooltip widget #92187

merged 2 commits into from
Oct 20, 2021

Conversation

Yugue
Copy link
Contributor

@Yugue Yugue commented Oct 20, 2021 •
edited
Loading

Added a tooltip to display explanations for increment step when initializing a release. There was already a tooltip widget made for conductor status in this PR. That widget has been exported and re-written as a common widget so it could also be used to initiate increment step tooltip and in the future, any other tooltips as well.

image

Issue

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Oct 20, 2021
@google-cla google-cla bot added the cla: yes label Oct 20, 2021
CaseyHillers
CaseyHillers approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

@Yugue Yugue changed the title Added a generic tooltip widget [conductor] Added a generic tooltip widget Oct 20, 2021
@Yugue Yugue merged commit ec429e0 into flutter:master Oct 20, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@Yugue @clocksmith
[conductor] Added a generic tooltip widget (flutter#92187)
e109b05 
* Added a generic tooltip widget

* added the header
@Yugue Yugue changed the title [conductor] Added a generic tooltip widget [release_dashboard] Added a generic tooltip widget Nov 18, 2021
@Yugue Yugue changed the title [release_dashboard] Added a generic tooltip widget [release_dashboard] Add a generic tooltip widget Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yugue @CaseyHillers