migrate integration.shard/vmservice_integration_test.dart to null safety #92812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: integration_test
|
@jmagman null safe mirgate pr |
jmagman
reviewed
Nov 1, 2021
packages/flutter_tools/test/integration.shard/vmservice_integration_test.dart
Outdated
Show resolved
Hide resolved
wanglikun7342
force-pushed
the
master_basic_project
branch
2 times, most recently
from
f2a5c78
to
4f9b1e5
Compare
wanglikun7342
force-pushed
the
master_basic_project
branch
from
4f9b1e5
to
2a77a9e
Compare
packages/flutter_tools/test/integration.shard/vmservice_integration_test.dart
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/vmservice_integration_test.dart
Show resolved
Hide resolved
|
@wanglikun7342 are you still working on this? |
christopherfujino
added
the
waiting for customer response
wanglikun7342
force-pushed
the
master_basic_project
branch
from
2a77a9e
to
9efd2dd
Compare
|
@christopherfujino i resolve it, please review again |
|
Gold has detected about 1 new digest(s) on patchset 1. |
wanglikun7342
force-pushed
the
master_basic_project
branch
from
9efd2dd
to
7d9a22e
Compare
wanglikun7342
force-pushed
the
master_basic_project
branch
from
7d9a22e
to
b2707fe
Compare
|
Gold has detected about 2 new digest(s) on patchset 1. |
christopherfujino
added
waiting for tree to go green
and removed
waiting for customer response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate integration.shard/vmservice_integration_test.dart to null safety
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
#71511
List which issues are fixed by this PR. You must list at least one issue.
NO
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.