Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Engine from aaacb670af16 to e022c9283c40 (4 revisions) #93510

Conversation

engine-flutter-autoroll
Copy link
Contributor

flutter/engine@aaacb67...e022c92

2021-11-11 zanderso@users.noreply.github.com Use a prebuilt Dart SDK during Fuchsia builds (flutter/engine#29680)
2021-11-11 magder@google.com Allow engine variants other than "host_debug" to be clang-tidy linted (flutter/engine#29668)
2021-11-11 wyte.sk133@gmail.com Do not update system UI overlays when the SDK version condition is not met (flutter/engine#29643)
2021-11-11 flar@google.com add trace events to cache sweeps (flutter/engine#29686)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@skia-gold
Copy link

Gold has detected about 6 new digest(s) on patchset 4.
View them at https://flutter-gold.skia.org/cl/github/93510

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #93510 at sha 1097533

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Nov 11, 2021
@Piinks
Copy link
Contributor

Piinks commented Nov 12, 2021

@kjlubick The images here have been triaged (none appear in the UI), but this says otherwise: https://flutter-gold.skia.org/json/v1/changelist_summary/github/93510

{
  "changelist_id": "93510",
  "patchsets": [
    {
      "new_images": 6,
      "new_untriaged_images": 2,
      "total_untriaged_images": 2,
      "patchset_id": "1097533850dc8ea158597597b2f17dd2339ee0d2",
      "patchset_order": 4
    }
  ],
  "outdated": false
}

@a-siva a-siva mentioned this pull request Nov 12, 2021
@fluttergithubbot fluttergithubbot merged commit b810aa7 into flutter:master Nov 12, 2021
@kjlubick
Copy link

I think it was a caching bug. I manually cleared the caches and that seems to have brightened things up. Can you file a bug for a way to invoke a cache-cleanse in the future?

@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-00e65052-59ea-4ecf-a907-2665477e966e-1636670820 branch November 18, 2021 23:36
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants