-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll Engine from aaacb670af16 to e022c9283c40 (4 revisions) #93510
Roll Engine from aaacb670af16 to e022c9283c40 (4 revisions) #93510
Conversation
Gold has detected about 6 new digest(s) on patchset 4. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@kjlubick The images here have been triaged (none appear in the UI), but this says otherwise: https://flutter-gold.skia.org/json/v1/changelist_summary/github/93510
|
I think it was a caching bug. I manually cleared the caches and that seems to have brightened things up. Can you file a bug for a way to invoke a cache-cleanse in the future? |
flutter/engine@aaacb67...e022c92
2021-11-11 zanderso@users.noreply.github.com Use a prebuilt Dart SDK during Fuchsia builds (flutter/engine#29680)
2021-11-11 magder@google.com Allow engine variants other than "host_debug" to be clang-tidy linted (flutter/engine#29668)
2021-11-11 wyte.sk133@gmail.com Do not update system UI overlays when the SDK version condition is not met (flutter/engine#29643)
2021-11-11 flar@google.com add trace events to cache sweeps (flutter/engine#29686)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md