Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devicelab] Add hot reload tests to presubmit #93684

Merged
merged 1 commit into from
Dec 1, 2021
Merged

[devicelab] Add hot reload tests to presubmit #93684

merged 1 commit into from
Dec 1, 2021

Conversation

CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Nov 15, 2021 •
edited
Loading

#92306

Fixes #94132

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Nov 15, 2021
@google-cla google-cla bot added the cla: yes label Nov 15, 2021
keyonghan
keyonghan approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers mentioned this pull request Nov 23, 2021
Closed
@fluttergithubbot fluttergithubbot merged commit c0da416 into flutter:master Dec 1, 2021
@CaseyHillers CaseyHillers deleted the devicelab-presubmit branch December 1, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead links in devicelab docs
3 participants
@CaseyHillers @keyonghan @fluttergithubbot