Fix CallbackShortcuts to only call shortcuts when triggered #93693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
gspencergoog
force-pushed
the
fix_callback_shortcuts
branch
from
0e8e3c1
to
d80f854
Compare
|
Doesn't work |
|
@dtat1991 Can you be more specific? |
|
Tested and seems to be working good for me now, thx @gspencergoog ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the
CallbackShortcutsclass to only call callbacks when the shortcut is triggered by the appropriate event, instead of whenever the shortcut accepts the event.Related Issues
Tests