Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ChangeNotifiers to be CustomPainters #9584

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Apr 25, 2017

Fixes #7648

@abarth
Copy link
Contributor

abarth commented Apr 26, 2017

That's clever.

@abarth
Copy link
Contributor

abarth commented Apr 26, 2017

LGTM

@Hixie Hixie merged commit 2e194d5 into flutter:master Apr 26, 2017
@Hixie Hixie deleted the customPaint branch April 26, 2017 21:30
amirh pushed a commit to amirh/flutter that referenced this pull request Jul 1, 2019
```
45b66b7 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559)" (flutter#9584)
fc1d86b Revert "Avoid a full screen overlay within virtual displays (flutter#9343)" (flutter#9581)
140b2ae  Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559)
94bb7a7 Adds API for retaining intermediate engine layers (flutter#9461)
7d1508d Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (flutter#9579)
7a0bbf9 Fixed memory leak by way of accidental retain on implicit self (flutter#9329)
```
amirh added a commit that referenced this pull request Jul 1, 2019
```
45b66b7 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (#9559)" (#9584)
fc1d86b Revert "Avoid a full screen overlay within virtual displays (#9343)" (#9581)
140b2ae  Roll src/third_party/dart b37aa3b036...1eb113ba27 (#9559)
94bb7a7 Adds API for retaining intermediate engine layers (#9461)
7d1508d Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (#9579)
7a0bbf9 Fixed memory leak by way of accidental retain on implicit self (#9329)
```
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
```
45b66b7 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559)" (flutter#9584)
fc1d86b Revert "Avoid a full screen overlay within virtual displays (flutter#9343)" (flutter#9581)
140b2ae  Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559)
94bb7a7 Adds API for retaining intermediate engine layers (flutter#9461)
7d1508d Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (flutter#9579)
7a0bbf9 Fixed memory leak by way of accidental retain on implicit self (flutter#9329)
```
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smooth the path to using a CustomPaint with a paintable ChangeNotifier
3 participants