Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch many Device methods to be async #9587

Merged
merged 5 commits into from
Apr 26, 2017
Merged

Switch many Device methods to be async #9587

merged 5 commits into from
Apr 26, 2017

Commits on Apr 25, 2017

  1. Switch many Device methods to be async 

    `adb` can sometimes hang, which will in turn hang the Dart isolate if
we're using `Process.runSync()`. This changes many of the `Device` methods
to return `Future<T>` in order to allow them to use the async process
methods. A future change will add timeouts to the associated calls so
that we can properly alert the user to the hung `adb` process.

This is work towards #7102, #9567
    @tvolkert
    tvolkert committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    b89c690 View commit details
    Browse the repository at this point in the history

  2. Fix tests and analyzer errors

    @tvolkert
    tvolkert committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    9893567 View commit details
    Browse the repository at this point in the history

  3. Convert some runCheckedSync() calls into runCheckedAsync() where … 

    …trivial to do so
    @tvolkert
    tvolkert committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    328bc08 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @tvolkert
    tvolkert committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    ed9193e View commit details
    Browse the repository at this point in the history

  5. Review comments

    @tvolkert
    tvolkert committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    f3b9147 View commit details
    Browse the repository at this point in the history