-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum required version to Xcode 13 #97746
Conversation
@@ -133,85 +133,50 @@ void main() { | |||
expect(fakeProcessManager.hasRemainingExpectations, isFalse); | |||
}); | |||
|
|||
testWithoutContext('xcodeVersionSatisfactory is false when version is less than minimum', () { | |||
testWithoutContext('version checks fail when version is less than minimum', () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I combined the isRequiredVersionSatisfactory
and isRecommendedVersionSatisfactory
tests since they had duplicated set ups.
@@ -147,7 +147,7 @@ class UserMessages { | |||
String xcodeLocation(String location) => 'Xcode at $location'; | |||
|
|||
String xcodeOutdated(String requiredVersion) => | |||
'Flutter requires a minimum Xcode version of $requiredVersion.\n' | |||
'Flutter requires Xcode $requiredVersion or higher.\n' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Flutter requires a minimum Xcode version of 13" looked silly.
Tests are failing because the builders are running older version of Xcode, will re-run tests once #91633 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to CocoaPods/CocoaPods#11828 (see #123890 for context). Bump the minimum Xcode version allowed by tooling to 14, released September 2022. ``` [!] Xcode - develop for iOS and macOS (Xcode 13.4) � Flutter requires Xcode 14 or higher. Download the latest version or update via the Mac App Store. ``` Fixes #125286. Previous bump at #97746.
Fixes #91634
Blocked by framework repo builder upgrade #98297 and #99318. DONE
Blocking engine repo builder upgrade #85555.
Previous bump at #77025.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.