Update minimum required version to Xcode 13 #97746

jmagman · 2022-02-03T23:24:12Z

Fixes #91634

Blocked by framework repo builder upgrade #98297 and #99318. DONE
Blocking engine repo builder upgrade #85555.

Previous bump at #77025.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-02-03T23:25:44Z

packages/flutter_tools/test/general.shard/macos/xcode_test.dart

@@ -133,85 +133,50 @@ void main() {
          expect(fakeProcessManager.hasRemainingExpectations, isFalse);
        });

-        testWithoutContext('xcodeVersionSatisfactory is false when version is less than minimum', () {
+        testWithoutContext('version checks fail when version is less than minimum', () {


I combined the isRequiredVersionSatisfactory and isRecommendedVersionSatisfactory tests since they had duplicated set ups.

jmagman · 2022-02-04T02:22:00Z

packages/flutter_tools/lib/src/base/user_messages.dart

@@ -147,7 +147,7 @@ class UserMessages {
  String xcodeLocation(String location) => 'Xcode at $location';

  String xcodeOutdated(String requiredVersion) =>
-      'Flutter requires a minimum Xcode version of $requiredVersion.\n'
+      'Flutter requires Xcode $requiredVersion or higher.\n'


"Flutter requires a minimum Xcode version of 13" looked silly.

jmagman · 2022-02-04T21:32:31Z

Tests are failing because the builders are running older version of Xcode, will re-run tests once #91633 is complete.

hellohuanlin

Nice!

christopherfujino

LGTM

…r#97746)

…97746)

…r#97746)

Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to CocoaPods/CocoaPods#11828 (see #123890 for context). Bump the minimum Xcode version allowed by tooling to 14, released September 2022. ``` [!] Xcode - develop for iOS and macOS (Xcode 13.4) â�� Flutter requires Xcode 14 or higher. Download the latest version or update via the Mac App Store. ``` Fixes #125286. Previous bump at #97746.

jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Feb 3, 2022

jmagman self-assigned this Feb 3, 2022

flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label Feb 3, 2022

jmagman commented Feb 3, 2022

View reviewed changes

jmagman commented Feb 4, 2022

View reviewed changes

jmagman requested review from hellohuanlin and christopherfujino February 4, 2022 21:33

hellohuanlin approved these changes Feb 4, 2022

View reviewed changes

Void48 mentioned this pull request Feb 10, 2022

Add a new entry to the .plist file to support 120Hz ProMotion displays on iOS chatsen/chatsen#146

Closed

christopherfujino approved these changes Feb 17, 2022

View reviewed changes

jmagman added 4 commits March 1, 2022 15:12

Update minimum required version to Xcode 13

617e867

Remove dedundant 'text'

1980fed

[intended]

0f503b6

Fix test

51ccd7d

jmagman force-pushed the xcode-13 branch from 1958271 to 51ccd7d Compare March 1, 2022 23:12

jmagman added the waiting for tree to go green label Mar 1, 2022

fluttergithubbot merged commit 8f360c9 into flutter:master Mar 2, 2022

jmagman deleted the xcode-13 branch March 2, 2022 00:37

engine-flutter-autoroll mentioned this pull request Mar 2, 2022

Roll Flutter from 38dbbb17f8ce to 8f360c977a61 (8 revisions) flutter/packages#1001

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

71594d7

…r#97746)

engine-flutter-autoroll mentioned this pull request Mar 2, 2022

Roll Flutter from 6c818d772a71 to 8f360c977a61 (2 revisions) flutter/plugins#4974

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 2, 2022

8f360c9 Update minimum required version to Xcode 13 (flutter/flutter#…

74406dc

…97746)

engine-flutter-autoroll mentioned this pull request Mar 2, 2022

Roll Flutter from 38dbbb17f8ce to 8f360c977a61 (8 revisions) flutter/packages#1002

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

5767d52

…r#97746)

engine-flutter-autoroll mentioned this pull request Mar 2, 2022

Roll Flutter from 38dbbb17f8ce to 8f360c977a61 (8 revisions) flutter/packages#1003

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

82852be

…r#97746)

engine-flutter-autoroll mentioned this pull request Mar 2, 2022

Roll Flutter from 38dbbb17f8ce to 12bec573449b (9 revisions) flutter/packages#1006

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

3209750

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

023a499

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

eb9cdaa

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

eeede24

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

32b3e5c

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

2f951fd

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

1d26d37

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

50017ac

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

35fe64d

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

380f2b5

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

5fcded9

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

79dd1a2

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

5cd4be8

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

96701fe

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

06eedcd

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

6b16a31

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

2e39466

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

9f81d5a

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

e212ccd

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

ac6f05d

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

698c446

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

f683661

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

a3b041d

…r#97746)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

8f360c977 Update minimum required version to Xcode 13 (flutter/flutte…

7f81d80

…r#97746)

jmagman mentioned this pull request Mar 18, 2022

Mac Web Engine timing out on Safari on Xcode 13.* #99885

Closed

jmagman mentioned this pull request Apr 27, 2023

Increase Xcode minimum version to 14 #125639

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update minimum required version to Xcode 13 #97746

Update minimum required version to Xcode 13 #97746

jmagman commented Feb 3, 2022 •

edited

Loading

jmagman Feb 3, 2022

jmagman Feb 4, 2022

jmagman commented Feb 4, 2022 •

edited

Loading

hellohuanlin left a comment

christopherfujino left a comment

Update minimum required version to Xcode 13 #97746

Update minimum required version to Xcode 13 #97746

Conversation

jmagman commented Feb 3, 2022 • edited Loading

Pre-launch Checklist

jmagman Feb 3, 2022

Choose a reason for hiding this comment

jmagman Feb 4, 2022

Choose a reason for hiding this comment

jmagman commented Feb 4, 2022 • edited Loading

hellohuanlin left a comment

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

jmagman commented Feb 3, 2022 •

edited

Loading

jmagman commented Feb 4, 2022 •

edited

Loading