Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Xcode version to 13a233 #98297

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Update Xcode version to 13a233 #98297

merged 3 commits into from
Feb 24, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Feb 11, 2022 •
edited

Re-land #98144.
Also revert #98210 override.

Merge after #98278 is resolved.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the team-infra Owned by Infrastructure team label Feb 11, 2022
@jmagman jmagman self-assigned this Feb 11, 2022
@jmagman jmagman mentioned this pull request Feb 11, 2022
Merged
@jmagman
Copy link
Member Author

jmagman commented Feb 11, 2022 •
edited

I thought the flake continued to happen after the revert, but it turns out the first run in the revert still incorrectly picked up the new version of macOS https://ci.chromium.org/p/flutter/builders/prod/Mac%20web_tool_tests/4898
Still need to figure out #98278 before this can merge again.

yusuf-goog
yusuf-goog approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@yusuf-goog yusuf-goog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman mentioned this pull request Feb 17, 2022
Merged
8 tasks
@goderbauer goderbauer added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Feb 18, 2022
@jmagman jmagman mentioned this pull request Feb 23, 2022
Closed
jmagman
jmagman commented Feb 23, 2022
View reviewed changes
.ci.yaml
Comment on lines +3054 to +3055
os: Mac-10.15 # Override OS and Xcode for https://github.com/flutter/flutter/issues/98278
xcode: 12c33
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an override for the failing web tests while the Chrome cipd package is updated

keyonghan
keyonghan approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmagman jmagman merged commit edc1612 into flutter:master Feb 24, 2022
@jmagman jmagman deleted the xcode-ci branch February 24, 2022 00:15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
edc16121f Update Xcode version to 13a233 (flutter/flutter#98297)
78aa0fc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
edc16121f Update Xcode version to 13a233 (flutter/flutter#98297)
bc4582c
@jmagman jmagman mentioned this pull request Feb 24, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
edc16121f Update Xcode version to 13a233 (flutter/flutter#98297)
b4a488b
@jmagman jmagman mentioned this pull request Feb 24, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
e2800dc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
a1f0869
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
f106f7a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
a6cdcc1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
4f12259
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
3558586
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
7ff8a73
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
120c776
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
d9db8ef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
68de1cb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
41f0410
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
012dbf2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
7e1f1ba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
edc1612 Update Xcode version to 13a233 (flutter/flutter#98297)
060db94
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jmagman @clocksmith
Update Xcode version to 13a233 (flutter#98297)
732952e
@jmagman jmagman mentioned this pull request Mar 9, 2022
Closed
@jmagman jmagman mentioned this pull request Mar 18, 2022
Closed
@keyonghan keyonghan mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@yusuf-goog yusuf-goog yusuf-goog approved these changes

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

@godofredoc godofredoc Awaiting requested review from godofredoc

@zanderso zanderso Awaiting requested review from zanderso

Assignees

@jmagman jmagman

Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmagman @keyonghan @yusuf-goog @goderbauer