[SelectionOverlay]Move the debug statement to the scope of the assertion. #108508

xu-baolin · 2022-07-28T03:51:35Z

Move the debug statement to the scope of the assertion.

goderbauer · 2022-07-28T16:59:26Z

packages/flutter/test/widgets/selectable_text_test.dart

+    await tester.pumpAndSettle();
+
+    await tester.pumpWidget(const SizedBox.shrink());
+    FlutterError.onError = handler;


could you get that error via tester.takeException instead of overriding the handler?

goderbauer · 2022-07-29T17:21:56Z

packages/flutter/lib/src/widgets/text_selection.dart

+       assert(() {
+         final OverlayState? overlay = Overlay.of(context, rootOverlay: true);
+         if (overlay == null) {
+           final List<DiagnosticsNode> information = <DiagnosticsNode>[
+             ErrorSummary('No Overlay widget found.'),
+             ErrorDescription(
+                 'No Overlay widget exists above $context.\n'
+                 'Usually the Navigator created by WidgetsApp provides the overlay. Perhaps your '
+                 'app content was created above the Navigator with the WidgetsApp builder parameter.'
+             ),
+           ];
+
+           throw FlutterError.fromParts(information);
+         }
+         return true;
+       }());


Actually, we have debugCheckHasOverlay [1]. Can we just use that here?

[1] https://master-api.flutter.dev/flutter/widgets/debugCheckHasOverlay.html

goderbauer

LGTM

…e assertion. (flutter/flutter#108508)

* M3 counter error style * polish * Update text_field_template.dart * Roll Flutter Engine from 3cba105 to cf0db3e (1 revision) (#108716) * resolve comments * Roll Plugins from 257eacb1e2aa to a6d42f1e01d3 (3 revisions) (#108738) * Override PlaceholderDimensions equality operator to avoid unnecessary TextPainter re-layouts (#108623) * Roll Flutter Engine from cf0db3e to aa90044 (1 revision) (#108734) * Roll Flutter Engine from aa90044 to 6d2fd23 (5 revisions) (#108744) * Fix lerp to eccentric circle. (#108743) * Roll Flutter Engine from 6d2fd23 to f182794 (4 revisions) (#108749) * Roll Flutter Engine from f182794 to 25e8021 (1 revision) (#108751) * Sync with flutter/.github#13 (#108754) * Roll Flutter Engine from 25e8021 to e771729 (2 revisions) (#108755) * clean-up analysis_options.yaml (#108747) * Fix ExpansionTile shows children background when expanded (#107834) * Create `containsSemantics` to allow for partial matching of semantics in tests. (#108573) * Roll Flutter Engine from e771729 to 7d0f6d2 (2 revisions) (#108757) * Enable conditional_uri_does_not_exist (#108652) * Roll Flutter Engine from 7d0f6d2 to b257966 (3 revisions) (#108763) * Roll Flutter Engine from b257966 to 60e5eb6 (3 revisions) (#108766) * Reland `Linux_samsung_a02 openpay_benchmarks__scroll_perf` (#108466) (#108769) * [SelectionOverlay]Move the debug statement to the scope of the assertion. (#108508) * Roll Flutter Engine from 60e5eb6 to 1c3b1b3 (11 revisions) (#108780) * Roll Flutter Engine from 1c3b1b3 to b607811 (1 revision) (#108782) * Roll Flutter Engine from b607811 to 3b2bd24 (1 revision) (#108784) * Roll Flutter Engine from 3b2bd24 to 0e5392c (1 revision) (#108788) * Roll Flutter Engine from 0e5392c to 4b19256 (1 revision) (#108793) * Roll Flutter Engine from 4b19256 to e0b5edc (2 revisions) (#108798) * Roll Flutter Engine from e0b5edc to b164c5c (1 revision) (#108814) * Update text_field.dart * Roll Flutter Engine from b164c5c to eb2b57b (4 revisions) (#108821) * Roll Plugins from a6d42f1e01d3 to 0d6d03a94ed5 (1 revision) (#108822) * Roll Flutter Engine from eb2b57b to 978d8e2 (2 revisions) (#108825) * Loupe Android + iOS (#107477) * added Magnifier for iOS and Android * Mark `Mac_ios microbenchmarks_ios_flaky` flaky (#108820) * Deprecate `toggleableActiveColor` (#97972) * Roll Flutter Engine from 978d8e2 to 2b31732 (4 revisions) (#108830) * [flutter_tools] Test that DAP process terminates at the end of a session (#108301) * Roll Flutter Engine from 2b31732 to 4e9c869 (1 revision) (#108833) * fix noop toString() diagnostics (#108836) * [flutter_tools] Migrate more tool tests to null-safety (#108639) * Revert "Fix ExpansionTile shows children background when expanded" (#108844) * Roll Flutter Engine from 4e9c869 to 6724561 (2 revisions) (#108838) * Marks Linux_android clipper_cache_perf__e2e_summary to be unflaky (#104088) * Update documentation to match implementation (#108843) * Reland "Add shadowColor and surfaceTintColor to Dialog and DialogTheme." #108718 * Roll Flutter Engine from 6724561 to f3deaba (8 revisions) (#108847) * Roll Flutter Engine from f3deaba to c07e1ac (2 revisions) (#108849) * Roll Flutter Engine from c07e1ac to a1e77ae (5 revisions) (#108850) * Roll Flutter Engine from a1e77ae to c456476 (2 revisions) (#108853) * Roll Flutter Engine from c456476 to 6cd744b (1 revision) (#108857) * Roll Flutter Engine from 6cd744b to 51296a6 (1 revision) (#108860) * Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (#108862) * Revert "Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (#108862)" (#108882) This reverts commit a880c4e. * Roll Plugins from 0d6d03a94ed5 to e74c42028d39 (5 revisions) (#108887) * Roll Flutter Engine from 51296a6 to 2c28298 (6 revisions) (#108899) * [flutter_test] Add flag to send device pointer events to the framework (#108430) * Roll Flutter Engine from 2c28298 to adba702 (2 revisions) (#108903) * fix flutter not finding custom device (#108884) * Force a11y services to off for complex_layout_semantics_perf test (#108906) * Update `equalsIgnoringHashCodes` to take a list of Strings (#108507) * [macOS] Use editing intents from engine (#105407) * Added `IconButtonTheme` and apply it to `IconButton` in M3 (#108332) * Created IconButtonTheme and apply it to IconButton * [web] Add onEntrypointLoaded to FlutterLoader. (#108776) * Roll pub packages (#108919) * [flutter_test] perf: find.ancestor (#108868) * Roll Flutter Engine from adba702 to 1188a80 (4 revisions) (#108922) * Bump github/codeql-action from 2.1.17 to 2.1.18 (#108923) * Remove some outdated ignores from framework (#108915) * Roll Flutter Engine from 1188a80 to 1743d1d (1 revision) (#108925) * Clean up ScrollbarPainter (#107179) * Remove outdated ignores (#108924) * Add more logs to diagnose Gold flake (#108930) * M3 counter error style * polish * Update text_field_template.dart * resolve comments * Update text_field.dart Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Tomasz Gucio <72562119+tgucio@users.noreply.github.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: Ian Hickson <ian@hixie.ch> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: pdblasi-google <109253501+pdblasi-google@users.noreply.github.com> Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com> Co-authored-by: xubaolin <xubaolin@oppo.com> Co-authored-by: Anthony Oleinik <48811365+antholeole@users.noreply.github.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Danny Tuppeny <danny@tuppeny.com> Co-authored-by: Phil Quitslund <pq@users.noreply.github.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: parkershepherd <me@parkershepherd.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by: Jia Hao <jiahaog@users.noreply.github.com> Co-authored-by: Hannes Winkler <hanneswinkler2000@web.de> Co-authored-by: Matej Knopp <matej.knopp@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: David Iglesias <ditman@gmail.com> Co-authored-by: Pascal Welsch <pascal@welsch.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ion. (flutter#108508)

* M3 counter error style * polish * Update text_field_template.dart * Roll Flutter Engine from 3cba105 to cf0db3e (1 revision) (flutter#108716) * resolve comments * Roll Plugins from 257eacb1e2aa to a6d42f1e01d3 (3 revisions) (flutter#108738) * Override PlaceholderDimensions equality operator to avoid unnecessary TextPainter re-layouts (flutter#108623) * Roll Flutter Engine from cf0db3e to aa90044 (1 revision) (flutter#108734) * Roll Flutter Engine from aa90044 to 6d2fd23 (5 revisions) (flutter#108744) * Fix lerp to eccentric circle. (flutter#108743) * Roll Flutter Engine from 6d2fd23 to f182794 (4 revisions) (flutter#108749) * Roll Flutter Engine from f182794 to 25e8021 (1 revision) (flutter#108751) * Sync with flutter/.github#13 (flutter#108754) * Roll Flutter Engine from 25e8021 to e771729 (2 revisions) (flutter#108755) * clean-up analysis_options.yaml (flutter#108747) * Fix ExpansionTile shows children background when expanded (flutter#107834) * Create `containsSemantics` to allow for partial matching of semantics in tests. (flutter#108573) * Roll Flutter Engine from e771729 to 7d0f6d2 (2 revisions) (flutter#108757) * Enable conditional_uri_does_not_exist (flutter#108652) * Roll Flutter Engine from 7d0f6d2 to b257966 (3 revisions) (flutter#108763) * Roll Flutter Engine from b257966 to 60e5eb6 (3 revisions) (flutter#108766) * Reland `Linux_samsung_a02 openpay_benchmarks__scroll_perf` (flutter#108466) (flutter#108769) * [SelectionOverlay]Move the debug statement to the scope of the assertion. (flutter#108508) * Roll Flutter Engine from 60e5eb6 to 1c3b1b3 (11 revisions) (flutter#108780) * Roll Flutter Engine from 1c3b1b3 to b607811 (1 revision) (flutter#108782) * Roll Flutter Engine from b607811 to 3b2bd24 (1 revision) (flutter#108784) * Roll Flutter Engine from 3b2bd24 to 0e5392c (1 revision) (flutter#108788) * Roll Flutter Engine from 0e5392c to 4b19256 (1 revision) (flutter#108793) * Roll Flutter Engine from 4b19256 to e0b5edc (2 revisions) (flutter#108798) * Roll Flutter Engine from e0b5edc to b164c5c (1 revision) (flutter#108814) * Update text_field.dart * Roll Flutter Engine from b164c5c to eb2b57b (4 revisions) (flutter#108821) * Roll Plugins from a6d42f1e01d3 to 0d6d03a94ed5 (1 revision) (flutter#108822) * Roll Flutter Engine from eb2b57b to 978d8e2 (2 revisions) (flutter#108825) * Loupe Android + iOS (flutter#107477) * added Magnifier for iOS and Android * Mark `Mac_ios microbenchmarks_ios_flaky` flaky (flutter#108820) * Deprecate `toggleableActiveColor` (flutter#97972) * Roll Flutter Engine from 978d8e2 to 2b31732 (4 revisions) (flutter#108830) * [flutter_tools] Test that DAP process terminates at the end of a session (flutter#108301) * Roll Flutter Engine from 2b31732 to 4e9c869 (1 revision) (flutter#108833) * fix noop toString() diagnostics (flutter#108836) * [flutter_tools] Migrate more tool tests to null-safety (flutter#108639) * Revert "Fix ExpansionTile shows children background when expanded" (flutter#108844) * Roll Flutter Engine from 4e9c869 to 6724561 (2 revisions) (flutter#108838) * Marks Linux_android clipper_cache_perf__e2e_summary to be unflaky (flutter#104088) * Update documentation to match implementation (flutter#108843) * Reland "Add shadowColor and surfaceTintColor to Dialog and DialogTheme." flutter#108718 * Roll Flutter Engine from 6724561 to f3deaba (8 revisions) (flutter#108847) * Roll Flutter Engine from f3deaba to c07e1ac (2 revisions) (flutter#108849) * Roll Flutter Engine from c07e1ac to a1e77ae (5 revisions) (flutter#108850) * Roll Flutter Engine from a1e77ae to c456476 (2 revisions) (flutter#108853) * Roll Flutter Engine from c456476 to 6cd744b (1 revision) (flutter#108857) * Roll Flutter Engine from 6cd744b to 51296a6 (1 revision) (flutter#108860) * Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (flutter#108862) * Revert "Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (flutter#108862)" (flutter#108882) This reverts commit a880c4e. * Roll Plugins from 0d6d03a94ed5 to e74c42028d39 (5 revisions) (flutter#108887) * Roll Flutter Engine from 51296a6 to 2c28298 (6 revisions) (flutter#108899) * [flutter_test] Add flag to send device pointer events to the framework (flutter#108430) * Roll Flutter Engine from 2c28298 to adba702 (2 revisions) (flutter#108903) * fix flutter not finding custom device (flutter#108884) * Force a11y services to off for complex_layout_semantics_perf test (flutter#108906) * Update `equalsIgnoringHashCodes` to take a list of Strings (flutter#108507) * [macOS] Use editing intents from engine (flutter#105407) * Added `IconButtonTheme` and apply it to `IconButton` in M3 (flutter#108332) * Created IconButtonTheme and apply it to IconButton * [web] Add onEntrypointLoaded to FlutterLoader. (flutter#108776) * Roll pub packages (flutter#108919) * [flutter_test] perf: find.ancestor (flutter#108868) * Roll Flutter Engine from adba702 to 1188a80 (4 revisions) (flutter#108922) * Bump github/codeql-action from 2.1.17 to 2.1.18 (flutter#108923) * Remove some outdated ignores from framework (flutter#108915) * Roll Flutter Engine from 1188a80 to 1743d1d (1 revision) (flutter#108925) * Clean up ScrollbarPainter (flutter#107179) * Remove outdated ignores (flutter#108924) * Add more logs to diagnose Gold flake (flutter#108930) * M3 counter error style * polish * Update text_field_template.dart * resolve comments * Update text_field.dart Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Tomasz Gucio <72562119+tgucio@users.noreply.github.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: Ian Hickson <ian@hixie.ch> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: pdblasi-google <109253501+pdblasi-google@users.noreply.github.com> Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com> Co-authored-by: xubaolin <xubaolin@oppo.com> Co-authored-by: Anthony Oleinik <48811365+antholeole@users.noreply.github.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Danny Tuppeny <danny@tuppeny.com> Co-authored-by: Phil Quitslund <pq@users.noreply.github.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: parkershepherd <me@parkershepherd.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by: Jia Hao <jiahaog@users.noreply.github.com> Co-authored-by: Hannes Winkler <hanneswinkler2000@web.de> Co-authored-by: Matej Knopp <matej.knopp@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: David Iglesias <ditman@gmail.com> Co-authored-by: Pascal Welsch <pascal@welsch.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jul 28, 2022

xu-baolin requested a review from LongCatIsLooong July 28, 2022 03:56

goderbauer reviewed Jul 28, 2022

View reviewed changes

xu-baolin force-pushed the xbl000728 branch from 7bdb162 to e338500 Compare July 29, 2022 02:31

xu-baolin requested a review from goderbauer July 29, 2022 03:14

goderbauer reviewed Jul 29, 2022

View reviewed changes

xu-baolin added 3 commits August 1, 2022 09:54

Move the debug statement to the scope of the assertion.

dbc5792

feedback

c80c270

feedback

672c703

xu-baolin force-pushed the xbl000728 branch from e338500 to 672c703 Compare August 1, 2022 03:20

xu-baolin requested a review from goderbauer August 1, 2022 06:06

goderbauer approved these changes Aug 1, 2022

View reviewed changes

xu-baolin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2022

auto-submit bot merged commit c4df6b6 into flutter:master Aug 2, 2022

engine-flutter-autoroll mentioned this pull request Aug 2, 2022

Roll Flutter from 9d96c7b8be2c to 708d2121cbcf (25 revisions) flutter/packages#2405

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2022

c4df6b6 [SelectionOverlay]Move the debug statement to the scope of th…

c3f9e0f

…e assertion. (flutter/flutter#108508)

engine-flutter-autoroll mentioned this pull request Aug 3, 2022

Roll Flutter from ac1aa511ca94 to 183d3e410102 (46 revisions) flutter/plugins#6177

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 3, 2022

c4df6b6 [SelectionOverlay]Move the debug statement to the scope of th…

6996ac1

…e assertion. (flutter/flutter#108508)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

[SelectionOverlay]Move the debug statement to the scope of the assert…

f89731f

…ion. (flutter#108508)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SelectionOverlay]Move the debug statement to the scope of the assertion. #108508

[SelectionOverlay]Move the debug statement to the scope of the assertion. #108508

xu-baolin commented Jul 28, 2022

goderbauer Jul 28, 2022

xu-baolin Jul 29, 2022

goderbauer Jul 29, 2022

goderbauer left a comment

[SelectionOverlay]Move the debug statement to the scope of the assertion. #108508

[SelectionOverlay]Move the debug statement to the scope of the assertion. #108508

Conversation

xu-baolin commented Jul 28, 2022

goderbauer Jul 28, 2022

Choose a reason for hiding this comment

xu-baolin Jul 29, 2022

Choose a reason for hiding this comment

goderbauer Jul 29, 2022

Choose a reason for hiding this comment

goderbauer left a comment

Choose a reason for hiding this comment