Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Samsung S10 tests in post-submit CI #99353

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Enable Samsung S10 tests in post-submit CI #99353

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e64490c
enable samsung tests
keyonghan Mar 1, 2022
038cddb
append s10
keyonghan Mar 1, 2022
aa83561
add s10 to tags
keyonghan Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 136 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,26 @@ platform_properties:
]
os: Linux
device_os: "N"
linux_samsung_s10:
properties:
caches: >-
[
{"name":"builder_linux_devicelab","path":"builder"},
{"name":"android_sdk","path":"android"},
{"name":"chrome_and_driver","path":"chrome"},
{"name":"flutter_sdk","path":"flutter sdk"},
{"name":"gradle","path":"gradle"},
{"name":"openjdk","path":"java"},
{"name":"pub_cache","path":".pub-cache"}
]
dependencies: >-
[
{"dependency": "android_sdk", "version": "version:31v8"},
{"dependency": "curl"},
{"dependency": "open_jdk"}
]
os: Linux
device_os: "R"
mac:
properties:
caches: >-
Expand Down Expand Up @@ -1455,6 +1475,18 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 backdrop_filter_perf__timeline_summary
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux","samsung"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the s10 not also be appended to the tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a nice to have. We now use this target tags only for statistic analysis. The tags here is different from the Skia tags, which are being collected in recipes side. One related cl: https://flutter-review.googlesource.com/c/recipes/+/27361.

Added for better info collection.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the SkiaPerf tags for these benchmarks? They should also be more specific that just "samsung" for the same reason.

Copy link
Contributor Author

@keyonghan keyonghan Mar 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a sample led run to show the tags:

{"arch": "intel", "device_type": "SM-G973U1", "device_version": "android-30", "host_type": "linux", "host_version": "debian-10.11"}

We are using adb shell getprop ro.product.model to tell the device type for all android devices.

task_name: backdrop_filter_perf__timeline_summary
benchmark: "true"
scheduler: luci

- name: Linux_android basic_material_app_android__compile
recipe: devicelab/devicelab_drone
presubmit: false
Expand Down Expand Up @@ -1593,6 +1625,26 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 complex_layout_scroll_perf__timeline_summary
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux", "samsung"]
task_name: complex_layout_scroll_perf__timeline_summary
dependencies: >-
[
{"dependency": "open_jdk", "version": "11"}
]
caches: >-
[
{"name": "openjdk", "path": "java11"}
]
benchmark: "true"
scheduler: luci

- name: Linux_android complex_layout_semantics_perf
recipe: devicelab/devicelab_drone
presubmit: false
Expand Down Expand Up @@ -1676,6 +1728,18 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 cubic_bezier_perf__timeline_summary
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux", "samsung"]
task_name: cubic_bezier_perf__timeline_summary
benchmark: "true"
scheduler: luci

- name: Linux_android cull_opacity_perf__e2e_summary
recipe: devicelab/devicelab_drone
presubmit: false
Expand All @@ -1698,6 +1762,18 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 cull_opacity_perf__timeline_summary
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux", "samsung"]
task_name: cull_opacity_perf__timeline_summary
benchmark: "true"
scheduler: luci

- name: Linux_android devtools_profile_start_test
recipe: devicelab/devicelab_drone
presubmit: false
Expand Down Expand Up @@ -2010,6 +2086,18 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 imagefiltered_transform_animation_perf__timeline_summary
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux", "samsung"]
task_name: imagefiltered_transform_animation_perf__timeline_summary
benchmark: "true"
scheduler: luci

- name: Linux_android image_list_reported_duration
recipe: devicelab/devicelab_drone
presubmit: false
Expand Down Expand Up @@ -2116,6 +2204,18 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 new_gallery__transition_perf
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux", "samsung"]
task_name: new_gallery__transition_perf
benchmark: "true"
scheduler: luci

- name: Linux_android picture_cache_perf__e2e_summary
recipe: devicelab/devicelab_drone
presubmit: false
Expand All @@ -2138,6 +2238,18 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 picture_cache_perf__timeline_summary
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux", "samsung"]
task_name: picture_cache_perf__timeline_summary
benchmark: "true"
scheduler: luci

- name: Linux_android android_picture_cache_complexity_scoring_perf__timeline_summary
recipe: devicelab/devicelab_drone
presubmit: false
Expand Down Expand Up @@ -2190,6 +2302,18 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 platform_views_scroll_perf__timeline_summary
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux", "samsung"]
task_name: platform_views_scroll_perf__timeline_summary
benchmark: "true"
scheduler: luci

- name: Linux_android platform_view__start_up
recipe: devicelab/devicelab_drone
presubmit: false
Expand Down Expand Up @@ -2242,6 +2366,18 @@ targets:
benchmark: "true"
scheduler: luci

- name: Linux_samsung_s10 textfield_perf__timeline_summary
recipe: devicelab/devicelab_drone
bringup: true # https://github.com/flutter/flutter/issues/92612
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux", "samsung"]
task_name: textfield_perf__timeline_summary
benchmark: "true"
scheduler: luci

- name: Linux_android tiles_scroll_perf__timeline_summary
recipe: devicelab/devicelab_drone
presubmit: false
Expand Down