Enable Samsung S10 tests in post-submit CI #99353
Conversation
.ci.yaml
Outdated
| @@ -48,6 +48,26 @@ platform_properties: | |||
| ] | |||
| os: Linux | |||
| device_os: "N" | |||
| linux_samsung: | |||
There was a problem hiding this comment.
Should we call this something generic like Linux_android_high_end?
Samsung has both high end and low end phones, so for new contributors it may be confusing
There was a problem hiding this comment.
One way is append s10 to make it more clear.
We may have different high_end phones in the future, like pixel. As for low_end, we may also have multiple, like samsung A02, existing motog4.
|
I'll send a fix for the flutter/infra issue Edit: CL in https://flutter-review.googlesource.com/c/infra/+/27540 |
.ci.yaml
Outdated
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux","samsung"] |
There was a problem hiding this comment.
Should the s10 not also be appended to the tags?
There was a problem hiding this comment.
It would be a nice to have. We now use this target tags only for statistic analysis. The tags here is different from the Skia tags, which are being collected in recipes side. One related cl: https://flutter-review.googlesource.com/c/recipes/+/27361.
Added for better info collection.
There was a problem hiding this comment.
What are the SkiaPerf tags for these benchmarks? They should also be more specific that just "samsung" for the same reason.
There was a problem hiding this comment.
Here is a sample led run to show the tags:
{"arch": "intel", "device_type": "SM-G973U1", "device_version": "android-30", "host_type": "linux", "host_version": "debian-10.11"}
We are using adb shell getprop ro.product.model to tell the device type for all android devices.
|
Will hold this PR until https://flutter-review.googlesource.com/c/recipes/+/27361 lands. That CL updates to use the |
goderbauer
added
team
Part of #92612.
With two Linux/SamsungS10 test beds in prod pool, we are ready to start testing in post-submit as
bringup: true.