Enable Samsung S10 tests in post-submit CI #99353
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,26 @@ platform_properties: | |
| ] | ||
| os: Linux | ||
| device_os: "N" | ||
| linux_samsung: | ||
| properties: | ||
| caches: >- | ||
| [ | ||
| {"name":"builder_linux_devicelab","path":"builder"}, | ||
| {"name":"android_sdk","path":"android"}, | ||
| {"name":"chrome_and_driver","path":"chrome"}, | ||
| {"name":"flutter_sdk","path":"flutter sdk"}, | ||
| {"name":"gradle","path":"gradle"}, | ||
| {"name":"openjdk","path":"java"}, | ||
| {"name":"pub_cache","path":".pub-cache"} | ||
| ] | ||
| dependencies: >- | ||
| [ | ||
| {"dependency": "android_sdk", "version": "version:31v8"}, | ||
| {"dependency": "curl"}, | ||
| {"dependency": "open_jdk"} | ||
| ] | ||
| os: Linux | ||
| device_os: "R" | ||
| mac: | ||
| properties: | ||
| caches: >- | ||
|
|
@@ -1455,6 +1475,18 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung backdrop_filter_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux","samsung"] | ||
|
There was a problem hiding this comment. Should the s10 not also be appended to the tags? There was a problem hiding this comment. It would be a nice to have. We now use this target tags only for statistic analysis. The Added for better info collection. There was a problem hiding this comment. What are the SkiaPerf tags for these benchmarks? They should also be more specific that just "samsung" for the same reason. There was a problem hiding this comment. Here is a sample led run to show the tags: We are using |
||
| task_name: backdrop_filter_perf__timeline_summary | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android basic_material_app_android__compile | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
@@ -1593,6 +1625,26 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung complex_layout_scroll_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux", "samsung"] | ||
| task_name: complex_layout_scroll_perf__timeline_summary | ||
| dependencies: >- | ||
| [ | ||
| {"dependency": "open_jdk", "version": "11"} | ||
| ] | ||
| caches: >- | ||
| [ | ||
| {"name": "openjdk", "path": "java11"} | ||
| ] | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android complex_layout_semantics_perf | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
@@ -1676,6 +1728,18 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung cubic_bezier_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux", "samsung"] | ||
| task_name: cubic_bezier_perf__timeline_summary | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android cull_opacity_perf__e2e_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
@@ -1698,6 +1762,18 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung cull_opacity_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux", "samsung"] | ||
| task_name: cull_opacity_perf__timeline_summary | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android devtools_profile_start_test | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
@@ -2010,6 +2086,18 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung imagefiltered_transform_animation_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux", "samsung"] | ||
| task_name: imagefiltered_transform_animation_perf__timeline_summary | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android image_list_reported_duration | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
@@ -2116,6 +2204,18 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung new_gallery__transition_perf | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux", "samsung"] | ||
| task_name: new_gallery__transition_perf | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android picture_cache_perf__e2e_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
@@ -2138,6 +2238,18 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung picture_cache_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux", "samsung"] | ||
| task_name: picture_cache_perf__timeline_summary | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android android_picture_cache_complexity_scoring_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
@@ -2190,6 +2302,18 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung platform_views_scroll_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux", "samsung"] | ||
| task_name: platform_views_scroll_perf__timeline_summary | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android platform_view__start_up | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
@@ -2242,6 +2366,18 @@ targets: | |
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_samsung textfield_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true # https://github.com/flutter/flutter/issues/92612 | ||
| presubmit: false | ||
| timeout: 60 | ||
| properties: | ||
| tags: > | ||
| ["devicelab","android","linux", "samsung"] | ||
| task_name: textfield_perf__timeline_summary | ||
| benchmark: "true" | ||
| scheduler: luci | ||
|
|
||
| - name: Linux_android tiles_scroll_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: false | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this something generic like Linux_android_high_end?
Samsung has both high end and low end phones, so for new contributors it may be confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way is append
s10to make it more clear.We may have different
high_endphones in the future, like pixel. As forlow_end, we may also have multiple, likesamsung A02, existingmotog4.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s10 sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @CaseyHillers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Appended.