Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Issue changing theme on Windows 10 #108

Closed
MostHated opened this issue Apr 20, 2020 · 1 comment · Fixed by #120
Closed

Issue changing theme on Windows 10 #108

MostHated opened this issue Apr 20, 2020 · 1 comment · Fixed by #120
Assignees
@guidezpl
Labels
bug Something isn't working P2 Priority 2 - Should have

Comments

@MostHated
Copy link

MostHated commented Apr 20, 2020 •
edited
Loading

Bug Report

I went to change the theme to "Dark" from "System" (my system is dark, but the app was set to light anyways from the start) and the settings menu changed color but the main screen only gave the error log entries seen at the bottom of this post:

I then closed the app, started it again and then it was able to change the theme color. I tried a third time and the error happened again. The screenshots below are from the 3rd attempt.

I have noticed that as soon as I manually adjust the size of the window by dragging one of the corners, the error goes away and things display properly but only if I resize it large enough.

Thanks,
-MH

Flutter doctor

[√] Flutter (Channel master, v1.18.0-6.0.pre.82, on Microsoft Windows [Version 10.0.19041.113], locale en-US)
    • Flutter version 1.18.0-6.0.pre.82 at C:\Users\mosthated\scoop\apps\flutter\current
    • Framework revision f35b673f2b (28 hours ago), 2020-04-19 02:45:01 +0530
    • Engine revision a5e0b2f2f2
    • Dart version 2.9.0 (build 2.9.0-1.0.dev 5b19445d9c)

 
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\mosthated\scoop\apps\android-sdk\current
    • Platform android-28, build-tools 29.0.3
    • ANDROID_HOME = C:\Users\mosthated\scoop\apps\android-sdk\current
    • Java binary at: C:\Users\mosthated\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\192.6392135\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.4.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.4.29905.134

[√] Android Studio (version 3.6)
    • Android Studio at C:\Users\mosthated\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\192.6392135
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] Connected device (1 available)
    • Windows • Windows • windows-x64 • Microsoft Windows [Version 10.0.19041.113]

To Reproduce

Steps to reproduce the behavior:

Start app => Settings => Theme => Dark

Expected behavior

The theme to change to dark, or already be set to dark when set to "System".

Screenshots

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser : None - Firefox is set to default if that matters

Error Log*

flutter: ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
[        ] flutter: The following assertion was thrown building _AnimatedHomePage(dirty, dependencies:
[        ] flutter: [_EffectiveTickerMode, _LocalizationsScope-[GlobalKey#69de4], _ModelBindingScope], state:
[        ] flutter: _AnimatedHomePageState#4d725(ticker inactive)):
[  +51 ms] flutter: 'package:gallery/pages/category_list_item.dart': Failed assertion: line 18 pos 16:
[        ] flutter: 'initiallyExpanded != null': is not true.
[        ] flutter: 
[        ] flutter: The relevant error-causing widget was:
[        ] flutter:   _AnimatedHomePage file:///E:/GitHub/gallery/lib/pages/home.dart:199:15
[        ] flutter: 
[        ] flutter: When the exception was thrown, this was the stack:
[        ] flutter: #2      new CategoryListItem (package:gallery/pages/category_list_item.dart:18:16)
[        ] flutter: #3      _AnimatedHomePageState.build (package:gallery/pages/home.dart:346:22)
[        ] flutter: #4      StatefulElement.build (package:flutter/src/widgets/framework.dart:4623:28)
[        ] flutter: #5      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4506:15)
[        ] flutter: #6      StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4679:11)
[        ] flutter: #7      Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #8      StatefulElement.update (package:flutter/src/widgets/framework.dart:4711:5)
[  +38 ms] flutter: #9      Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #10     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #11     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #12     StatelessElement.update (package:flutter/src/widgets/framework.dart:4587:5)
[        ] flutter: #13     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #14     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #15     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #16     ProxyElement.update (package:flutter/src/widgets/framework.dart:4866:5)
[        ] flutter: #17     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #18     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #19     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #20     ProxyElement.update (package:flutter/src/widgets/framework.dart:4866:5)
[        ] flutter: #21     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #22     RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:5526:32)
[        ] flutter: #23     MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:5961:17)
[        ] flutter: #24     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #25     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #26     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4679:11)
[        ] flutter: #27     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #28     StatefulElement.update (package:flutter/src/widgets/framework.dart:4711:5)
[        ] flutter: #29     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #30     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[  +43 ms] flutter: #31     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #32     ProxyElement.update (package:flutter/src/widgets/framework.dart:4866:5)
[        ] flutter: #33     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #34     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #35     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4679:11)
[        ] flutter: #36     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #37     StatefulElement.update (package:flutter/src/widgets/framework.dart:4711:5)
[        ] flutter: #38     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #39     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:5841:14)
[        ] flutter: #40     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #41     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #42     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #43     StatelessElement.update (package:flutter/src/widgets/framework.dart:4587:5)
[  +44 ms] flutter: #44     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #45     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:5841:14)
[        ] flutter: #46     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #47     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #48     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4679:11)
[        ] flutter: #49     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #50     StatefulElement.update (package:flutter/src/widgets/framework.dart:4711:5)
[        ] flutter: #51     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #52     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #53     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4679:11)
[  +46 ms] flutter: #54     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #55     StatefulElement.update (package:flutter/src/widgets/framework.dart:4711:5)
[        ] flutter: #56     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #57     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #58     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #59     ProxyElement.update (package:flutter/src/widgets/framework.dart:4866:5)
[        ] flutter: #60     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[  +23 ms] flutter: #61     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #62     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #63     ProxyElement.update (package:flutter/src/widgets/framework.dart:4866:5)
[        ] flutter: #64     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #65     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #66     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4679:11)
[        ] flutter: #67     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #68     StatefulElement.update (package:flutter/src/widgets/framework.dart:4711:5)
[        ] flutter: #69     Element.updateChild (package:flutter/src/widgets/framework.dart:3205:15)
[        ] flutter: #70     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4531:16)
[        ] flutter: #71     Element.rebuild (package:flutter/src/widgets/framework.dart:4222:5)
[        ] flutter: #72     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2627:33)
[        ] flutter: #73     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:864:20)
[        ] flutter: #74     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:284:5)
[        ] flutter: #75     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1074:15)
[        ] flutter: #76     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1013:9)
[        ] flutter: #77     SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:929:5)
[        ] flutter: #81     _invoke (dart:ui/hooks.dart:261:10)
[  +45 ms] flutter: #82     _drawFrame (dart:ui/hooks.dart:219:3)
[        ] flutter: (elided 5 frames from class _AssertionError and dart:async)
[        ] flutter: 
[        ] flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════

flutter: Another exception was thrown: 'package:gallery/pages/category_list_item.dart': Failed assertion: line 18 pos 16: 'initiallyExpanded != null': is not true.
@MostHated MostHated added the bug Something isn't working label Apr 20, 2020
@rami-a rami-a added the P2 Priority 2 - Should have label Apr 20, 2020
@guidezpl guidezpl self-assigned this Apr 23, 2020
@guidezpl guidezpl mentioned this issue Apr 24, 2020
Merged
@guidezpl
Copy link
Member

FYI, platform brightness detection is not yet implemented on Windows, but the error you were running into will be fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@guidezpl guidezpl

Labels
bug Something isn't working P2 Priority 2 - Should have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing isTestMode to GalleryOptions
3 participants
@rami-a @MostHated @guidezpl