New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go_router] Fix deprecation message for GoRouterState.namedLocation #3092
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
5ad5be2
to
25e30c8
Compare
test-exempt: fixing deprecation warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like there is a merge conflict, can you rebase off latest main? |
Done -- just needed to merge pubspec.yaml & CHANGELOG.md. |
There is another merge conflict. There was a lot of traffic on go_router package recently, can you rebase again? |
@chunhtai Done |
It looks like there is another merge conflict |
Fix deprecation message for `GoRouterState.namedLocation` -- it should point to `GoRouter.of(context).namedLocation`, not `GoRouter.of(context).routeInformationParser.namedLocation` (the latter does not exist). Previously mentioned here: flutter@bdc07b6#r88804919
@chunhtai I've updated it again. I don't want to sound snarky, but has any consideration been put into a different way to manage the release process to facilitate this continuous delivery? Every single merge failure has been due to conflicting changes from CHANGELOG.md and pubspec.yaml, and it seems like if instead those files were generated from data in the commit message, and a CI check validated that those elements were present in the change, the merge process would be a lot smoother. It has taken three weeks to land a fix for an error message in a deprecation notice to guide users to the correct API. E.g. something like |
What is the |
Yes I also felt the release process has not worked very well for this package especially we got a lot of traffic recently. I hope it will get I will see what i can do. you can ignore submit queue for now. It should turn green on itself at some point, and the label will automerge this pr when it does |
* ad48ee5 [go_router] Fix some broken links in doc (flutter/packages#3288) * 58ac45e [go_router_builder] Add support for Iterable, List and Set to TypedGoRoute (flutter/packages#2679) * 0edae25 Export super types in route_data.dart library (flutter/packages#3286) * 8ad3fde [go_router] Add `GoRouter.maybeOf` (flutter/packages#3216) * 13ee644 [flutter_migrate] Skip slow tests (flutter/packages#3270) * 3cc754a Update .gitignore with missing values from flutter/plugins (flutter/packages#3265) * c0f0a22 [ci] Re-enable pathified unit tests (flutter/packages#3268) * 5834b4c [go_router]: implemented helpers for ShellRoute (flutter/packages#2730) * af5906b [extension_gsi] Update extension to support gsi 5 and 6. (flutter/packages#3235) * 195f4e8 Merge in plugin README and CONTRIBUTING (flutter/packages#3252) * fab47af [go_router] Disable logging in tests (flutter/packages#3263) * 25f0f70 [various] Update flutter/plugins links (flutter/packages#3256) * 2e16733 Merge flutter/plugins (flutter/packages#3233) * 324a7f2 Exclude more tests on Windows * 334b58e Adjust test configs * 69e6dac [go_router_builder] Generate replace method in RouteExtension (flutter/packages#2838) * 193e454 Merge repository metadata * 18715d7 Merge remote-tracking branch 'plugins-packages/main' into merge-flutter-plugins * f2d802d Roll Flutter from ae8d051 to 7175de4 (4 revisions) (flutter/packages#3232) * 6f1b1e8 Roll Flutter from 33e4d21 to ae8d051 (6 revisions) (flutter/packages#3229) * a162a98 Roll Flutter from 0be7c3f to 33e4d21 (5 revisions) (flutter/packages#3227) * ab5a8c0 [tool] Allow importing packages with NEXT (flutter/packages#3215) * ce9c61b Roll Flutter from 170539f to 0be7c3f (38 revisions) (flutter/packages#3225) * 9747469 Fix deprecation message for GoRouterState.namedLocation (flutter/packages#3092) * 6e4431f [go_router] Bump example `compileSdkVersion` and `package_info_plus` dependency version (flutter/packages#3219) * 925bea8 [pigeon] Validate generated files in CI (flutter/packages#3224) * 3094867 Move iOS Swift unit tests back to Cirrus (flutter/packages#3221) * 763d025 [pigeon] Eliminate some of the test pigeons (flutter/packages#3213)
Fix deprecation message for
GoRouterState.namedLocation
-- it should point toGoRouter.of(context).namedLocation
, notGoRouter.of(context).routeInformationParser.namedLocation
(the latter does not exist).Previously mentioned here: bdc07b6#r88804919
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.