[pigeon] Eliminate some of the test pigeons #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems a test is still in need of updating for windows |
|
Yep, I'm already on it. I meant to check that before I opened the PR, but forgot overnight. |
|
No actual test updates needed, I just had to remove references to the generated output of some files. I enabled builds for almost everything on Windows even where I didn't backfill unit tests since it meant we at least had compilation coverage. |
tarrinneal
reviewed
Feb 16, 2023
| /** | ||
| * A data class containing a List, used in unit tests. | ||
| * | ||
| * <p>Generated class from Pigeon that represents data sent in messages. |
There was a problem hiding this comment.
where is this <p> coming from?
There was a problem hiding this comment.
If we're not generating it, I guess the autoformatter?
There was a problem hiding this comment.
I just looked into it and it seems to be standard practice for doc comment paragraph separation. Might be a good idea to add it to our comment parsing tools
tarrinneal
approved these changes
Feb 16, 2023
tarrinneal
added
the
autosubmit
ditman
added a commit
to ditman/flutter-flutter
that referenced
this pull request
Feb 24, 2023
* ad48ee5 [go_router] Fix some broken links in doc (flutter/packages#3288) * 58ac45e [go_router_builder] Add support for Iterable, List and Set to TypedGoRoute (flutter/packages#2679) * 0edae25 Export super types in route_data.dart library (flutter/packages#3286) * 8ad3fde [go_router] Add `GoRouter.maybeOf` (flutter/packages#3216) * 13ee644 [flutter_migrate] Skip slow tests (flutter/packages#3270) * 3cc754a Update .gitignore with missing values from flutter/plugins (flutter/packages#3265) * c0f0a22 [ci] Re-enable pathified unit tests (flutter/packages#3268) * 5834b4c [go_router]: implemented helpers for ShellRoute (flutter/packages#2730) * af5906b [extension_gsi] Update extension to support gsi 5 and 6. (flutter/packages#3235) * 195f4e8 Merge in plugin README and CONTRIBUTING (flutter/packages#3252) * fab47af [go_router] Disable logging in tests (flutter/packages#3263) * 25f0f70 [various] Update flutter/plugins links (flutter/packages#3256) * 2e16733 Merge flutter/plugins (flutter/packages#3233) * 324a7f2 Exclude more tests on Windows * 334b58e Adjust test configs * 69e6dac [go_router_builder] Generate replace method in RouteExtension (flutter/packages#2838) * 193e454 Merge repository metadata * 18715d7 Merge remote-tracking branch 'plugins-packages/main' into merge-flutter-plugins * f2d802d Roll Flutter from ae8d051 to 7175de4 (4 revisions) (flutter/packages#3232) * 6f1b1e8 Roll Flutter from 33e4d21 to ae8d051 (6 revisions) (flutter/packages#3229) * a162a98 Roll Flutter from 0be7c3f to 33e4d21 (5 revisions) (flutter/packages#3227) * ab5a8c0 [tool] Allow importing packages with NEXT (flutter/packages#3215) * ce9c61b Roll Flutter from 170539f to 0be7c3f (38 revisions) (flutter/packages#3225) * 9747469 Fix deprecation message for GoRouterState.namedLocation (flutter/packages#3092) * 6e4431f [go_router] Bump example `compileSdkVersion` and `package_info_plus` dependency version (flutter/packages#3219) * 925bea8 [pigeon] Validate generated files in CI (flutter/packages#3224) * 3094867 Move iOS Swift unit tests back to Cirrus (flutter/packages#3221) * 763d025 [pigeon] Eliminate some of the test pigeons (flutter/packages#3213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list.dartandasync_handlers.dartintocore_tests.dart. This involved adding a couple of new APIs that I expect to be temporary; it's not ideal, but it's simpler (and now more clearly commented) than having random extra pigeon input files.android_unittest.dart; some of the tests using it have been removed as they are not useful relative to the integration tests we now run (e.g., ensuring that serialization and deserialization of a data class works without asserting anything about its structure), and the others have been adjusted to use the newcore_test.dartAPI instead.This is just a natural cut point since the remaining files are either more complex and/or are also used in the Dart unit test project that itself needs some rework; more still needs to be done to remove more files.
Part of flutter/flutter#115168
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).