Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera_platform_interface] Adds support for setting the image file format #5593

Merged

Conversation

Mairramer
Copy link
Contributor

@Mairramer Mairramer commented Dec 6, 2023

Part of #4586

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan / @tarrinneal for secondary review

Also for some context: #4586 (review)

@bparrishMines bparrishMines added the federated: partial_changes PR that contains changes for only a single package of a federated plugin change label Dec 14, 2023
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 14, 2023
@auto-submit auto-submit bot merged commit 942f1bd into flutter:main Dec 14, 2023
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 15, 2023
flutter/packages@1151191...3f2e16b

2023-12-15 magder@google.com Swap some iOS package CODEOWNERS (flutter/packages#5667)
2023-12-14 ychris@google.com [in_app_purchase_storekit]add storekit configuration to the example app (flutter/packages#5411)
2023-12-14 50643541+Mairramer@users.noreply.github.com [camera_platform_interface] Adds support for setting the image file format (flutter/packages#5593)
2023-12-14 34871572+gmackall@users.noreply.github.com [path_provider_android] Re-enable getExternalStorageDirectories test (flutter/packages#5668)
2023-12-14 ndelanou@users.noreply.github.com [go_router] fix(docs): typo in example extra_codec.dart (flutter/packages#5570)
2023-12-14 stuartmorgan@google.com [ios_platform_images] Adopt code-excerpts (flutter/packages#5682)
2023-12-14 me@nils.re [camera] Fix typo "intialize" in doc comments (flutter/packages#4949)
2023-12-14 engine-flutter-autoroll@skia.org Roll Flutter from 11a9cb7 to a51e33a (30 revisions) (flutter/packages#5680)
2023-12-14 katelovett@google.com [two_dimensional_scrollables] Post 3.16 stable tech debt clean up (flutter/packages#5671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App federated: partial_changes PR that contains changes for only a single package of a federated plugin change p: camera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants