Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] add heif support image iOS #4586

Merged
merged 95 commits into from
Jan 24, 2024

Conversation

Mairramer
Copy link
Contributor

@Mairramer Mairramer commented Jul 29, 2023

Add support to heic format on IOS on take picture.

Based on flutter/flutter#119795

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Mairramer Mairramer changed the title add heic support image iOS [camera_avfoundation] add heic support image iOS Jul 29, 2023
@Mairramer Mairramer changed the title [camera_avfoundation] add heic support image iOS [camera] add heic support image iOS Jul 29, 2023
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the interface. I went ahead and updated some of the documentation as well. You can now create a new PR with just the platform interface changes and we can review and land that first.

@bparrishMines bparrishMines added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Dec 5, 2023
@Mairramer
Copy link
Contributor Author

@bparrishMines I created the PR #5593 to camera_platform_interface

@jmagman
Copy link
Member

jmagman commented Jan 17, 2024

#5593 merged, looks like there are conflicts with the CHANGELOG and Xcode project. Can you rebase?
@bparrishMines is there anything else needed to get this merged?

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2024
@auto-submit auto-submit bot merged commit ba43d73 into flutter:main Jan 24, 2024
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 25, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 25, 2024
flutter/packages@8fbdf65...21b5abb

2024-01-24 pageli328@gmail.com Add rfw widgets (flutter/packages#5661)
2024-01-24 50643541+Mairramer@users.noreply.github.com [camera] add heif support image iOS (flutter/packages#4586)
2024-01-24 jsharp83@gmail.com [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796)
2024-01-24 43054281+camsim99@users.noreply.github.com [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659)
2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967)
2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter from 5b673c2 to 19b06f4 (21 revisions) (flutter/packages#5968)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Add support to heic format on IOS on take picture.

Based on flutter/flutter#119795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App federated: all_changes PR that contains changes for all packages for a federated plugin change p: camera platform-ios platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants