This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[ci] Disable analyze on stable for web plugins that contains null safety integration tests. #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1bfabd0.
ditman
approved these changes
Mar 5, 2021
ditman
reviewed
Mar 5, 2021
cyanglaz
changed the title
ditman
reviewed
Mar 5, 2021
Co-authored-by: David Iglesias <ditman@gmail.com>
ditman
reviewed
Mar 5, 2021
Remove web examples before running analyze in stable. Don't attempt to build web examples in stable.
ditman
approved these changes
Mar 5, 2021
script/incremental_build.sh
Outdated
Comment on lines
51
to
53
| (cd "$REPO_DIR" && plugin_tools "${ACTIONS[@]}" --plugins="$CHANGED_PACKAGES" --exclude="$ALL_EXCLUDED" ${PLUGIN_SHARDING[@]}) | ||
| (cd "$REPO_DIR" && plugin_tools "${ACTIONS[@]}" --exclude="$ALL_EXCLUDED" ${PLUGIN_SHARDING[@]}) | ||
|
|
||
| # (cd "$REPO_DIR" && plugin_tools "${ACTIONS[@]}" --plugins="$CHANGED_PACKAGES" --exclude="$ALL_EXCLUDED" ${PLUGIN_SHARDING[@]}) |
There was a problem hiding this comment.
This needs to be reverted before merging
ditman
reviewed
Mar 5, 2021
| script: | ||
| - flutter channel $CHANNEL | ||
| - ./script/incremental_build.sh analyze | ||
| ## TODO(cyanglaz): |
There was a problem hiding this comment.
I've created this issue: flutter/flutter#77429
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2021
…null safety integration tests. (flutter/plugins#3681)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2021
…null safety integration tests. (flutter/plugins#3681)
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Mar 8, 2021
* master: [google_sign_in] fix test(flutter#3690) [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689) [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686) Import flutter_test for future compatibility (flutter#3665) [ci] Disable analyze on stable for web plugins that contains null safety integration tests. (flutter#3681) Bring HTML inputs into view automatically (flutter#3655) [in_app_purchase] presentCodeRedemptionSheet (flutter#3274) [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679) Update CI config for Flutter 2 (flutter#3674) [image_picker] fix flutter/flutter#71927 (flutter#3676) [google_maps_flutter_web] Move integration tests to example. (flutter#3675) [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins (flutter#3673) # Conflicts: # packages/webview_flutter/CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes the unused flutter driver and integration test deps in
extension_google_sign_in_as_googleapis_authFixes
This PR also