Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter_web] Move integration tests to example. #3675

Merged
merged 2 commits into from
Mar 4, 2021
Merged

[google_maps_flutter_web] Move integration tests to example. #3675

merged 2 commits into from
Mar 4, 2021

Conversation

ditman
Copy link
Member

@ditman ditman commented Mar 4, 2021

This PR moves the integration tests of this package to conform with the latest best practices for web plugins.

Testing

  • All tests run from their new locations.
  • The new test succeeds, and lets the user know that tests have moved to the example.
  • The plugin continues to work when manually tested in the google_maps_flutter example app.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan March 4, 2021 01:14
@ditman ditman requested a review from cyanglaz as a code owner March 4, 2021 01:14
@google-cla google-cla bot added the cla: yes label Mar 4, 2021
stuartmorgan
stuartmorgan approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan merged commit 8ab62c5 into flutter:master Mar 4, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
8ab62c5 [google_maps_flutter_web] Move integration tests to example. (f…
2f7aa8b 
…lutter/plugins#3675)
@ditman ditman deleted the move-maps-tests-to-example branch March 4, 2021 02:44
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Mar 4, 2021
@engine-flutter-autoroll
8ab62c5 [google_maps_flutter_web] Move integration tests to example. (f…
71a3dc3 
…lutter/plugins#3675) (#77197)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Mar 8, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
fc41c1e 
* master:
  [google_sign_in] fix test(flutter#3690)
  [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689)
  [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686)
  Import flutter_test for future compatibility (flutter#3665)
  [ci] Disable analyze on stable for web plugins that contains null safety integration tests.  (flutter#3681)
  Bring HTML inputs into view automatically (flutter#3655)
  [in_app_purchase] presentCodeRedemptionSheet (flutter#3274)
  [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679)
  Update CI config for Flutter 2 (flutter#3674)
  [image_picker] fix flutter/flutter#71927 (flutter#3676)
  [google_maps_flutter_web] Move integration tests to example. (flutter#3675)
  [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins  (flutter#3673)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes p: google_maps_flutter platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ditman @stuartmorgan