Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image_picker] Remove the otherElement check for static text in XCUITests #71927

Closed
cyanglaz opened this issue Dec 8, 2020 · 1 comment · Fixed by flutter/plugins#3676 or #77269
Closed

[image_picker] Remove the otherElement check for static text in XCUITests #71927

cyanglaz opened this issue Dec 8, 2020 · 1 comment · Fixed by flutter/plugins#3676 or #77269
Assignees
@cyanglaz
Labels
good first issue Relatively approachable for first-time contributors p: image_picker The Image Picker plugin. P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically

Comments

@cyanglaz
Copy link
Contributor

cyanglaz commented Dec 8, 2020

flutter/engine#22811 updated the a11y element type to staticText.
This caused the image picker XCUITests to require to looking for both "otherElements" and "staticTexts" for master and stable.

We should remove the "otherElement" check when flutter/engine#22811 rolled into stable.
@cyanglaz cyanglaz self-assigned this Dec 8, 2020
@cyanglaz cyanglaz added P3 Issues that are less important to the Flutter project p: first party p: image_picker The Image Picker plugin. good first issue Relatively approachable for first-time contributors platform-ios iOS applications specifically labels Dec 8, 2020
@cyanglaz cyanglaz mentioned this issue Dec 10, 2020
Merged
13 tasks
@ghost ghost mentioned this issue Dec 26, 2020
Closed
13 tasks
daadu added a commit to daadu/plugins that referenced this issue Mar 4, 2021
@daadu
[image_picker] fix flutter/flutter#71927
fdf7227
@daadu daadu mentioned this issue Mar 4, 2021
Merged
11 tasks
fluttergithubbot pushed a commit to flutter/plugins that referenced this issue Mar 4, 2021
@daadu
[image_picker] fix flutter/flutter#71927 (#3676)
2518218
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Mar 4, 2021
@engine-flutter-autoroll
2518218 [image_picker] fix flutter#71927 (flutter/plugins#3676)
94b211b
fluttergithubbot pushed a commit that referenced this issue Mar 4, 2021
@engine-flutter-autoroll
2518218 [image_picker] fix #71927 (flutter/plugins#3676) (#77269)
9397c37
NickalasB added a commit to NickalasB/plugins that referenced this issue Mar 8, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
fc41c1e 
* master:
  [google_sign_in] fix test(flutter#3690)
  [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689)
  [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686)
  Import flutter_test for future compatibility (flutter#3665)
  [ci] Disable analyze on stable for web plugins that contains null safety integration tests.  (flutter#3681)
  Bring HTML inputs into view automatically (flutter#3655)
  [in_app_purchase] presentCodeRedemptionSheet (flutter#3274)
  [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679)
  Update CI config for Flutter 2 (flutter#3674)
  [image_picker] fix flutter/flutter#71927 (flutter#3676)
  [google_maps_flutter_web] Move integration tests to example. (flutter#3675)
  [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins  (flutter#3673)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
nksteven pushed a commit to nksteven/ez_image_picker that referenced this issue Aug 29, 2023
@daadu
[image_picker] fix flutter/flutter#71927 (#3676)
4b7f3d4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cyanglaz cyanglaz

Labels
good first issue Relatively approachable for first-time contributors p: image_picker The Image Picker plugin. P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically
Projects
None yet
Milestone
No milestone
2 participants
@cyanglaz @pedromassangocode