Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] publish-plugin check against pub to determine if a release should happen #4068

Merged
merged 7 commits into from Jun 24, 2021
Merged

[flutter_plugin_tools] publish-plugin check against pub to determine if a release should happen #4068

merged 7 commits into from Jun 24, 2021

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Jun 17, 2021 •
edited

This PR removes a TODO where we used to check if a release should happen against git tags, instead, we check against pub.

Also, when auto-publish and the package is manually released, the CI will continue to fail without this change.

Fixes flutter/flutter#81047

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jun 17, 2021
@cyanglaz
Copy link
Contributor Author

@stuartmorgan This is important to make the tree green if the package is published manually before automatically.
Without this change, ci would always be red if the version is published manually. Because pub publish exits with code 1 if the version to be published has already been published.

stuartmorgan
stuartmorgan approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this fixes potential tree breakage, but this is a ton of test boilerplate that we should really extract a helper for.

@stuartmorgan stuartmorgan merged commit d1c3e83 into flutter:master Jun 24, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2021
@engine-flutter-autoroll
d1c3e83 [flutter_plugin_tools] publish-plugin check against pub to …
92bb97f 
…determine if a release should happen (flutter/plugins#4068)
@cyanglaz cyanglaz deleted the publish_plugin_check_against_pub branch June 25, 2021 00:08
@cyanglaz
Copy link
Contributor Author

LGTM since this fixes potential tree breakage, but this is a ton of test boilerplate that we should really extract a helper for.

Issue created: flutter/flutter#85276

Ralph-Li pushed a commit to Insight-Timer/plugins that referenced this pull request Jul 1, 2021
@adad184
Merge branch 'upstream_v0_8_1+3'
75d8b60 
* upstream_v0_8_1+3: (99 commits)
  [image_picker] Fixed IOException when cache directory is removed (flutter#4117)
  [in_app_purchase] Fix app exceptions caused by missing App Store receipt (flutter#4096)
  Add Basic Junit Tests to some plugins (flutter#4108)
  [image_picker]Update example app (flutter#4103)
  [flutter_plugin_tools] Restructure version-check (flutter#4111)
  Split some Cirrus script steps (flutter#4112)
  [flutter_plugin_tools] Migrate java-test to new base command (flutter#4105)
  [flutter_plugin_tools] ignore flutter_plugin_tools when publishing (flutter#4110)
  [in_app_purchase] Add support for SKPaymentQueueDelegate and showPriceConsentIfNeeded (flutter#4085)
  [flutter_plugin_tools] release 0.3.0 (flutter#4109)
  Migrate command, add failure test, remove skip (flutter#4106)
  Don't install cocoapods; use the version in the image (flutter#4104)
  [flutter_plugin_tools] Migrate analyze to new base command (flutter#4084)
  Add release status badge to README (flutter#4102)
  Build all iOS example apps on current Flutter stable (flutter#4101)
  [url_launcher] Fix test button check for iOS 15 (flutter#4088)
  Update .ci.yaml documentation link (flutter#4090)
  [image_picker] Updated pickImage and pickVideo docs to expose the possible errors that can be thrown (flutter#4089)
  [flutter_plugin_tools] `publish-plugin` check against pub to determine if a release should happen (flutter#4068)
  [webview_flutter] Suppress iOS 9 deprecation warnings (flutter#4100)
  ...

# Conflicts:
#	packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@amantoux
[flutter_plugin_tools] publish-plugin check against pub to determin…
f3694cd 
…e if a release should happen (flutter#4068)

This PR removes a TODO where we used to check if a release should happen against git tags, instead, we check against pub.

Also, when auto-publish and the package is manually released, the CI will continue to fail without this change.

Fixes flutter/flutter#81047
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@fotiDim
[flutter_plugin_tools] publish-plugin check against pub to determin…
b0838fb 
…e if a release should happen (flutter#4068)

This PR removes a TODO where we used to check if a release should happen against git tags, instead, we check against pub.

Also, when auto-publish and the package is manually released, the CI will continue to fail without this change.

Fixes flutter/flutter#81047
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
2 participants
@cyanglaz @stuartmorgan