Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Build all iOS example apps on current Flutter stable #4101

Merged
merged 2 commits into from Jun 25, 2021
Merged

Build all iOS example apps on current Flutter stable #4101

merged 2 commits into from Jun 25, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 24, 2021 •
edited

Run build-examples --ipa on Flutter 2.2.2 (current stable). Allow the Flutter tool and CocoaPods to migrate project files.

This will reduce working copy changes when the example projects are built for testing.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Jun 24, 2021
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
@jmagman
Copy link
Member Author

jmagman commented Jun 24, 2021

Should I update the CHANGELOGs with ## NEXTs?

jmagman
jmagman commented Jun 24, 2021
View reviewed changes
packages/battery/battery/example/ios/Runner.xcodeproj/project.pbxproj
@@ -9,10 +9,6 @@
/* Begin PBXBuildFile section */
1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */; };
3B3967161E833CAA004F5970 /* AppFrameworkInfo.plist in Resources */ = {isa = PBXBuildFile; fileRef = 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */; };
3B80C3941E831B6300D905FE /* App.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3B80C3931E831B6300D905FE /* App.framework */; };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter/flutter#51453

packages/battery/battery/example/ios/Runner.xcodeproj/project.pbxproj
@@ -315,7 +287,6 @@
/* Begin XCBuildConfiguration section */
97C147031CF9000F007C117D /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = 9740EEB21CF90195004384FC /* Debug.xcconfig */;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter/flutter#54691

...es/battery/battery/example/ios/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata
@@ -2,6 +2,6 @@
<Workspace
version = "1.0">
<FileRef
location = "group:Runner.xcodeproj">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter/flutter#73508

packages/connectivity/connectivity/example/ios/Runner.xcodeproj/project.pbxproj
@@ -229,7 +216,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" thin";
shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" embed_and_thin";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter/flutter#51453

packages/path_provider/path_provider/example/linux/flutter/generated_plugin_registrant.cc Outdated
@@ -2,8 +2,6 @@
// Generated file. Do not edit.
//

// clang-format off
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter/flutter#76662

packages/battery/battery/example/ios/Runner.xcodeproj/project.pbxproj
@@ -229,22 +216,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" thin";
};
4096151B6BA12D6D4D7DD96A /* [CP] Embed Pods Frameworks */ = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Objective-C Podfiles are set up to use libraries, not frameworks. CocoaPods is removing the build step that embeds the frameworks into the app.

@jmagman
Copy link
Member Author

jmagman commented Jun 24, 2021 •
edited

Hm, the formatter doesn't like the generated empty generated_plugin_registrant...

-
-void RegisterPlugins(flutter::PluginRegistry* registry) {
-}
+void RegisterPlugins(flutter::PluginRegistry* registry) {}

@jmagman
Copy link
Member Author

jmagman commented Jun 24, 2021

Hm, the formatter doesn't like the generated empty generated_plugin_registrant...

I reverted the Windows and Linux project changes, sticking to just iOS for this PR.

@stuartmorgan
Copy link
Contributor

Hm, the formatter doesn't like the generated empty generated_plugin_registrant...

-
-void RegisterPlugins(flutter::PluginRegistry* registry) {
-}
+void RegisterPlugins(flutter::PluginRegistry* registry) {}

Yeah, this is why we turned off auto-format in the templates recently on master.

stuartmorgan
stuartmorgan approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 25, 2021
@fluttergithubbot fluttergithubbot merged commit 6c5ecec into flutter:master Jun 25, 2021
@jmagman jmagman deleted the build-ipa branch June 25, 2021 00:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2021
@engine-flutter-autoroll
6c5ecec Build all iOS example apps on current Flutter stable (flutter…
94d07cc 
…/plugins#4101)
Ralph-Li pushed a commit to Insight-Timer/plugins that referenced this pull request Jul 1, 2021
@adad184
Merge branch 'upstream_v0_8_1+3'
75d8b60 
* upstream_v0_8_1+3: (99 commits)
  [image_picker] Fixed IOException when cache directory is removed (flutter#4117)
  [in_app_purchase] Fix app exceptions caused by missing App Store receipt (flutter#4096)
  Add Basic Junit Tests to some plugins (flutter#4108)
  [image_picker]Update example app (flutter#4103)
  [flutter_plugin_tools] Restructure version-check (flutter#4111)
  Split some Cirrus script steps (flutter#4112)
  [flutter_plugin_tools] Migrate java-test to new base command (flutter#4105)
  [flutter_plugin_tools] ignore flutter_plugin_tools when publishing (flutter#4110)
  [in_app_purchase] Add support for SKPaymentQueueDelegate and showPriceConsentIfNeeded (flutter#4085)
  [flutter_plugin_tools] release 0.3.0 (flutter#4109)
  Migrate command, add failure test, remove skip (flutter#4106)
  Don't install cocoapods; use the version in the image (flutter#4104)
  [flutter_plugin_tools] Migrate analyze to new base command (flutter#4084)
  Add release status badge to README (flutter#4102)
  Build all iOS example apps on current Flutter stable (flutter#4101)
  [url_launcher] Fix test button check for iOS 15 (flutter#4088)
  Update .ci.yaml documentation link (flutter#4090)
  [image_picker] Updated pickImage and pickVideo docs to expose the possible errors that can be thrown (flutter#4089)
  [flutter_plugin_tools] `publish-plugin` check against pub to determine if a release should happen (flutter#4068)
  [webview_flutter] Suppress iOS 9 deprecation warnings (flutter#4100)
  ...

# Conflicts:
#	packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@jmagman @amantoux
Build all iOS example apps on current Flutter stable (flutter#4101)
67e7e21
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@jmagman @fotiDim
Build all iOS example apps on current Flutter stable (flutter#4101)
4583d3b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees

@jmagman jmagman

Labels
cla: yes p: battery Edits files for a battery plugin p: connectivity p: device_info p: package_info p: sensors p: share p: wifi_info_flutter platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@jmagman @stuartmorgan @fluttergithubbot