Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] Migrate java-test to new base command #4105

Merged
merged 4 commits into from Jun 28, 2021
Merged

[flutter_plugin_tools] Migrate java-test to new base command #4105

merged 4 commits into from Jun 28, 2021

Conversation

stuartmorgan
Copy link
Contributor

Switches java-test to the new base command that handles the boilerplate of looping over target packages.

Includes test improvements:

  • Adds failure tests; previously no failure cases were covered.
  • Captures output so test output isn't spammed with command output.

Part of flutter/flutter#83413

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Jun 25, 2021
gaaclarke
gaaclarke approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stuartmorgan stuartmorgan merged commit a02b8f2 into flutter:master Jun 28, 2021
@stuartmorgan stuartmorgan deleted the tool-package-looper-java-test branch June 28, 2021 18:26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 28, 2021
@engine-flutter-autoroll
a02b8f2 [flutter_plugin_tools] Migrate java-test to new base command (f…
9605a91 
…lutter/plugins#4105)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 28, 2021
@engine-flutter-autoroll
a02b8f2 [flutter_plugin_tools] Migrate java-test to new base command (f…
d63cb83 
…lutter/plugins#4105) (#85470)
Ralph-Li pushed a commit to Insight-Timer/plugins that referenced this pull request Jul 1, 2021
@adad184
Merge branch 'upstream_v0_8_1+3'
75d8b60 
* upstream_v0_8_1+3: (99 commits)
  [image_picker] Fixed IOException when cache directory is removed (flutter#4117)
  [in_app_purchase] Fix app exceptions caused by missing App Store receipt (flutter#4096)
  Add Basic Junit Tests to some plugins (flutter#4108)
  [image_picker]Update example app (flutter#4103)
  [flutter_plugin_tools] Restructure version-check (flutter#4111)
  Split some Cirrus script steps (flutter#4112)
  [flutter_plugin_tools] Migrate java-test to new base command (flutter#4105)
  [flutter_plugin_tools] ignore flutter_plugin_tools when publishing (flutter#4110)
  [in_app_purchase] Add support for SKPaymentQueueDelegate and showPriceConsentIfNeeded (flutter#4085)
  [flutter_plugin_tools] release 0.3.0 (flutter#4109)
  Migrate command, add failure test, remove skip (flutter#4106)
  Don't install cocoapods; use the version in the image (flutter#4104)
  [flutter_plugin_tools] Migrate analyze to new base command (flutter#4084)
  Add release status badge to README (flutter#4102)
  Build all iOS example apps on current Flutter stable (flutter#4101)
  [url_launcher] Fix test button check for iOS 15 (flutter#4088)
  Update .ci.yaml documentation link (flutter#4090)
  [image_picker] Updated pickImage and pickVideo docs to expose the possible errors that can be thrown (flutter#4089)
  [flutter_plugin_tools] `publish-plugin` check against pub to determine if a release should happen (flutter#4068)
  [webview_flutter] Suppress iOS 9 deprecation warnings (flutter#4100)
  ...

# Conflicts:
#	packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@stuartmorgan @amantoux
[flutter_plugin_tools] Migrate java-test to new base command (flutter…
1efee2c 
…#4105)

Switches `java-test` to the new base command that handles the boilerplate of looping over target packages.

Includes test improvements:
- Adds failure tests; previously no failure cases were covered.
- Captures output so test output isn't spammed with command output.

Part of flutter/flutter#83413
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
[flutter_plugin_tools] Migrate java-test to new base command (flutter…
facfd06 
…#4105)

Switches `java-test` to the new base command that handles the boilerplate of looping over target packages.

Includes test improvements:
- Adds failure tests; previously no failure cases were covered.
- Captures output so test output isn't spammed with command output.

Part of flutter/flutter#83413
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @gaaclarke