This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[image_picker] Improve image_picker for iOS to handle more image types #6812
Merged
auto-submit
merged 10 commits into
flutter:main
from
vashworth:image_picker_images_not_loading
Dec 16, 2022
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2cb9a17
Improve image picker for ios to handle more image types
vashworth ca426d1
Update release info
vashworth 10970db
different svg, remove raw test
vashworth a48fa37
change pro raw image
vashworth 2f4bba5
change pro raw image
vashworth 23f07f4
Merge remote-tracking branch 'upstream/main' into image_picker_images…
vashworth ecc0a8b
add error log
vashworth 0313fb8
fix formatting
vashworth 1e65814
fix image identifiers in test
vashworth 3636c7d
get image type identifier from itemProvider in test
vashworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+92 Bytes
packages/image_picker/image_picker_ios/example/ios/TestImages/bmpImage.bmp
Binary file not shown.
Binary file added
BIN
+3.13 KB
packages/image_picker/image_picker_ios/example/ios/TestImages/heicImage.heic
Binary file not shown.
Binary file added
BIN
+354 Bytes
packages/image_picker/image_picker_ios/example/ios/TestImages/icnsImage.icns
Binary file not shown.
Binary file added
BIN
+139 Bytes
packages/image_picker/image_picker_ios/example/ios/TestImages/icoImage.ico
Binary file not shown.
Binary file added
BIN
+7.91 KB
packages/image_picker/image_picker_ios/example/ios/TestImages/proRawImage.dng
Binary file not shown.
3 changes: 3 additions & 0 deletions
3
packages/image_picker/image_picker_ios/example/ios/TestImages/svgImage.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.09 KB
packages/image_picker/image_picker_ios/example/ios/TestImages/tiffImage.tiff
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to test the pre-iOS 14 codepath without using
PHPickerResult
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, that code is dead,
FLTPHPickerSaveImageToPathOperation
is only available on iOS 14.