Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ColorScheme to show the newly added color roles #2299

Merged
merged 5 commits into from
May 22, 2024
Merged

Update ColorScheme to show the newly added color roles #2299

merged 5 commits into from
May 22, 2024

Conversation

QuncCccccc
Copy link
Contributor

This PR is to fix #2289 and add newly added ColorScheme roles since flutter/flutter#144273

Pre-launch Checklist

  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

@QuncCccccc QuncCccccc marked this pull request as draft May 21, 2024 19:56
@QuncCccccc QuncCccccc marked this pull request as ready for review May 21, 2024 20:26
@domesticmouse
Copy link
Contributor

@QuncCccccc is this on stable?

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented May 22, 2024 •
edited

@QuncCccccc is this on stable?

Yes, I think so:) I can see the code change(new colors) on stable branch: https://github.com/flutter/flutter/blob/stable/packages/flutter/lib/src/material/color_scheme.dart

parlough
parlough approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

@parlough parlough merged commit 649e0e4 into main May 22, 2024
13 of 14 checks passed
@parlough parlough deleted the update_color_scheme branch May 22, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update material _3_demo for ColorScheme updates
3 participants
@QuncCccccc @domesticmouse @parlough