Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run OptiPNG on PNGs uploaded to any Flutter repo. #3589

Closed
matthew-carroll opened this issue Aug 13, 2018 · 6 comments
Closed
Labels
cl.wont-fix Issue closed as it either can't be or won't be fixed co.proposal Community ask to change an approach or process for docs.flutter.dev e1-hours Effort: < 8 hrs infra.design Relates to the design of docs.flutter.dev infra.structure Relates to the tools that create docs.flutter.dev p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.

Comments

@matthew-carroll
Copy link
Contributor

Automatically run OptiPNG on PNGs uploaded to any Flutter repo.

Every image a developer uploads to any Flutter repo (framework, website, examples, etc) needs to go through OptiPNG. Currently this is left to individual developers before putting up a PR. We should integrate this as either a pre or post commit hook on PRs so that developers don't have to worry about this, and reviewers don't have to police it.

CC @xster

@Sfshaza
Copy link
Contributor

Sfshaza commented Aug 18, 2018

I thought we were doing that, but maybe only on the *.dartlang sites. @chalin?

@chalin
Copy link
Contributor

chalin commented Aug 18, 2018

Yes, we have scripts for the *.dartlang sites that sweep over all images, but had decided to not integrate them into the build checks / or set them up via hooks. IMHO, it is probably enough to setup a cron job to check this offline, outside of the main site-update workflow.

I've created #1162 to track this for flutter/website.

@zoeyfan
Copy link
Contributor

zoeyfan commented Jan 3, 2020

@matthew-carroll , I am triaging our bug database, and noticed that this bug was opened in 2018, but had no traction afterwards. Just curious if we are still planning to do anything here. If not, shall we just go ahead and close it?

@xster
Copy link
Member

xster commented Jan 6, 2020

I think this is still relevant and would save another mechanical review step for contributors.

@kf6gpe
Copy link
Contributor

kf6gpe commented Jan 27, 2020

As this is an improvement for the web site, moving to the web site repo.

@kf6gpe kf6gpe transferred this issue from flutter/flutter Jan 27, 2020
@legalcodes legalcodes added infra.structure Relates to the tools that create docs.flutter.dev co.proposal Community ask to change an approach or process for docs.flutter.dev labels Mar 25, 2020
@parlough parlough added p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. e1-hours Effort: < 8 hrs ltw-triage labels May 24, 2023
@atsansone atsansone added the infra.design Relates to the design of docs.flutter.dev label Aug 25, 2023
@atsansone
Copy link
Contributor

This would be superceded with a push to webp per #6487. Closing this issue.

@atsansone atsansone closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2023
@atsansone atsansone added the cl.wont-fix Issue closed as it either can't be or won't be fixed label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl.wont-fix Issue closed as it either can't be or won't be fixed co.proposal Community ask to change an approach or process for docs.flutter.dev e1-hours Effort: < 8 hrs infra.design Relates to the design of docs.flutter.dev infra.structure Relates to the tools that create docs.flutter.dev p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.
Projects
None yet
Development

No branches or pull requests

9 participants