Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update screenshot on 'Creating flavors for Flutter' page #8746

Open
Tracked by #9976
, #7979
...
samekard-dev opened this issue Mar 14, 2023 · 2 comments
Open
Tracked by #9976
, #7979
...

Update screenshot on 'Creating flavors for Flutter' page #8746

samekard-dev opened this issue Mar 14, 2023 · 2 comments
Labels
co.PRs-welcome Contributors encouraged to file a PR dev.flavors Relates to flavor configuration for deployment devos.macOS Relates to developing apps on macOS platform e1-hours Effort: < 8 hrs fix.screenshot Needs new or update to screenshot from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. target.iOS Target apps on the iOS Platform

Comments

@samekard-dev
Copy link

Page URL

https://docs.flutter.dev/deployment/flavors/

Page source

https://github.com/flutter/website/tree/main/src/deployment/flavors.md

Describe the problem

In the Using flavors in iOS section, the Product Name is rewritten, but the screenshot shows that Project is selected, but Target should be selected.
The Product Name is in both Project and Target, so even if the Project is rewritten, it is overwritten by the Target setting.

Expected fix

Screenshot with Target selected

Additional context

No response
@sfshaza2
Copy link
Contributor

@parlough, when you have a minute, can you retake that screen shot?

@danagbemava-nc danagbemava-nc added st.triage.triage-team Triage team reviewing and categorizing the issue p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs and removed st.triage.triage-team Triage team reviewing and categorizing the issue labels Mar 15, 2023
@sfshaza2 sfshaza2 added the co.PRs-welcome Contributors encouraged to file a PR label Mar 20, 2023
@parlough
Copy link
Member

I likely won't get to this right away, but I'll keep it on my list in case someone else doesn't get to it soon.

It seems there might be some other images that need updates as well: #8238

@atsansone atsansone added the target.iOS Target apps on the iOS Platform label May 15, 2023
@atsansone atsansone added from.page-issue Reported in a reader-filed concern fix.screenshot Needs new or update to screenshot labels May 22, 2023
@atsansone atsansone changed the title [PAGE ISSUE]: 'Creating flavors for Flutter' Update screenshot on 'Creating flavors for Flutter' page May 23, 2023
@atsansone atsansone added devos.macOS Relates to developing apps on macOS platform ltw-triage labels May 23, 2023
@atsansone atsansone transferred this issue from flutter/website May 24, 2023
@atsansone atsansone added the dev.flavors Relates to flavor configuration for deployment label Jun 7, 2023
@atsansone atsansone mentioned this issue Jun 7, 2023
Closed
11 tasks
@atsansone atsansone mentioned this issue Dec 28, 2023
Open
27 tasks
@atsansone atsansone self-assigned this Mar 21, 2024
@atsansone atsansone removed their assignment Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
co.PRs-welcome Contributors encouraged to file a PR dev.flavors Relates to flavor configuration for deployment devos.macOS Relates to developing apps on macOS platform e1-hours Effort: < 8 hrs fix.screenshot Needs new or update to screenshot from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. target.iOS Target apps on the iOS Platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@atsansone @parlough @sfshaza2 @danagbemava-nc @samekard-dev