Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing due to old/incorrect example #94

Closed
sethladd opened this issue Nov 20, 2015 · 3 comments
Closed

Build failing due to old/incorrect example #94

sethladd opened this issue Nov 20, 2015 · 3 comments
Labels
fix.bug Needs fix of incorrect copy, code, or visual

Comments

@sethladd
Copy link
Contributor

From travis:

1 issue found; analyzed 10 source files in 13.3s.
[warning] The argument type '(BuildContext, Product, int) → dynamic' cannot be assigned to the parameter type 'ItemBuilder' at example/tutorial_md_8.dart, line 472.
The command "./tool/travis.sh" exited with 1.
@sethladd sethladd added the fix.bug Needs fix of incorrect copy, code, or visual label Nov 20, 2015
@sethladd
Copy link
Contributor Author

cc @abarth

@abarth
Copy link
Contributor

abarth commented Nov 20, 2015

Yeah, Travis is still using the flutter package from pub. /me will fix.

@abarth abarth self-assigned this Nov 20, 2015
@abarth
Copy link
Contributor

abarth commented Nov 24, 2015

This is fixed now.

@abarth abarth closed this as completed Nov 24, 2015
@abarth abarth removed their assignment Feb 5, 2016
parlough added a commit to parlough/website that referenced this issue Jan 10, 2023
* Avoid extra border on embedded DartPads (flutter#8044)

Do so by moving the code-excerpt border to the pre elements used by snippets rather than the code-excerpt div itself.

* Bump site-shared from `444b310` to `faddba8` (flutter#8033)

Bumps [site-shared](https://github.com/dart-lang/site-shared) from `444b310` to `faddba8`.
- [Release notes](https://github.com/dart-lang/site-shared/releases)
- [Commits](dart-lang/site-shared@444b310...faddba8)

---
updated-dependencies:
- dependency-name: site-shared
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>

* Add overrides to fix print styles (flutter#8042)

Fixes flutter#2974

Co-authored-by: Brett Morgan <brettmorgan@google.com>

* Add redirect for old rendering doc (flutter#8047)

* Update mentions of Observatory to DevTools (flutter#8046)

* Update mentions of Observatory to DevTools

Also updates the instructions for opening DevTools

* Update connecting header

* Update name to Timeline events chart

* Add big juicy link to new codelab (flutter#8049)

* Add big link to the new codelab

* Remove files no longer needed

* Add an Oxford comma, naturally

* Clarify the info box at top of web codelab

* Fly-by fix of broken fragment links

* Bump examples/codelabs from `288ea9e` to `fc9dbfd` (flutter#8048)

* Scroll active sidenav entry into view on load (flutter#8050)

* updated banner for 17 days of Flutter (flutter#8052)

* Remove links to old “First app” codelab (flutter#8051)

* fix: typo (flutter#8053)

`a error` -> `an error` [link](https://owl.purdue.edu/owl/general_writing/grammar/articles_a_versus_an.html#:~:text=%22A%22%20goes%20before%20words%20that%20begin%20with%20consonants.&text=%22An%22%20goes%20before%20words%20that,an%20apricot)

Co-authored-by: Brett Morgan <brettmorgan@google.com>

* Fix applicationId mention and formatting in Android flavors section (flutter#8056)

* Fix a bunch of broken or outdated external links (flutter#8055)

* Fix non-response images on inspector page (flutter#8058)

Fixes flutter#6496

* Bump pigeon in /examples/development/platform_integration (flutter#8063)

Bumps [pigeon](https://github.com/flutter/packages/tree/main/packages) from 4.2.14 to 5.0.0.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/pigeon-v5.0.0/packages)

---
updated-dependencies:
- dependency-name: pigeon
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update firebase.json (flutter#8067)

Update link destination for pull-request-revert-api-v2. Previous link was not working correctly.

* Fix sidebar collapse icon alignment (flutter#8068)

* Enable Jekyll frontmatter and some liquid validation (flutter#8059)

Fixes flutter#3489

* Bump actions/setup-node from 3.5.1 to 3.6.0 (flutter#8061)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.5.1 to 3.6.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@8c91899...64ed1c7)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 3.2.0 to 3.3.0 (flutter#8060)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@755da8c...ac59398)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Split Flutter for iOS developers into pages for SwiftUI and UIKit (flutter#8070)

* Split Flutter for iOS developers into page for SwiftUI and UIKit

* Fix redirect link

* Update some links to new articles

* Remove extra SwiftUI link

* Adding Parker (flutter#8074)

* Fixed mobile layout on 'Creating responsive and adaptive apps' page (flutter#8073)

Updated the the mobile responsiveness of a video url.

Co-authored-by: Parker Lougheed <parlough@gmail.com>

* Fix incorrect migration sample in RenderObjectElement migrations (flutter#8078)

* Fix formatting of 'Unsupported platforms' table (flutter#8079)

* Fix first web app codelab returning private state lint (flutter#8081)

* Fix multiple API doc links (flutter#8082)

* Fix images not staying in content on 'Building adaptive apps' (flutter#8077)

Fixes flutter#7470

* Uncomment post-publish SwiftUI doc link (flutter#8075)

* feat/solidart-state-management-option (flutter#8071)

Add `solidart` as a state management option

* Add go link for Platinum Tests (flutter#8069)

Co-authored-by: Brett Morgan <brettmorgan@google.com>

* Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter#8085)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@83fd05a...0b7f8ab)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Followup adjustments to first Flutter app codelab (flutter#8087)

* Fix “Building layouts (step 0)”

* Fix “Adding interactivity (step 0)”

* Update examples/layout/base/lib/main.dart

Co-authored-by: Parker Lougheed <parlough@gmail.com>

* Regenerate

Co-authored-by: Parker Lougheed <parlough@gmail.com>

* Finalize followup adjustments for the new "First Flutter app" codelab (flutter#8088)

This updates the following:

- [Testing accessibility on mobile](https://docs.flutter.dev/development/accessibility-and-localization/accessibility#testing-accessibility-on-mobile) relying on and referencing the old, created app and the [Accessibility Guideline API](https://api.flutter.dev/flutter/flutter_test/AccessibilityGuideline-class.html)

_Issues fixed by this PR (if any):_ Fixes flutter#8054

Co-authored-by: Parker Lougheed <parlough@gmail.com>

* Bump diff2html-cli from 5.2.7 to 5.2.9 (flutter#8084)

Bumps [diff2html-cli](https://github.com/rtfpessoa/diff2html-cli) from 5.2.7 to 5.2.9.
- [Release notes](https://github.com/rtfpessoa/diff2html-cli/releases)
- [Commits](rtfpessoa/diff2html-cli@5.2.7...5.2.9)

---
updated-dependencies:
- dependency-name: diff2html-cli
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Clean up and fix some issues on 'Android views' page (flutter#8089)

* Cleans up and fixes some issues on Android platform views page

* Fix leading whitespace

* Update internationalization documentation (flutter#8065)

* init

* more changes + code excerpts

* revert package lock? didn't change any packages so idk why this is updating

* add l10n config info

* fix issues

* update code snippets?

* fix

* fix code snippets

* fix stable

* finally fixed

* fix everything

* Update src/development/accessibility-and-localization/internationalization.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update src/development/accessibility-and-localization/internationalization.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update src/development/accessibility-and-localization/internationalization.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update src/development/accessibility-and-localization/internationalization.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update src/development/accessibility-and-localization/internationalization.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update src/development/accessibility-and-localization/internationalization.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update examples/internationalization/gen_l10n_example/lib/examples.txt

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update examples/internationalization/gen_l10n_example/lib/main.dart

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update src/development/accessibility-and-localization/internationalization.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Update src/development/accessibility-and-localization/internationalization.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* fix some stuff

* Apply suggestions from code review

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* add comment about case-sensitive-ness of select comparisons

* Apply suggestions from code review

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* fix code-excerpts

* fix code-excerpt issues

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

* Replace outdated links to site-shared writing wiki (flutter#8092)

* Make the example visually explicit (flutter#8083)

Make the example visually explicit with the native android reference: https://developer.android.com/training/multiscreen/screendensities#TaskProvideAltBmp

* Update pull request template for website freeze (flutter#8041)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brett Morgan <brettmorgan@google.com>
Co-authored-by: Filip Hracek <filiph@users.noreply.github.com>
Co-authored-by: Shamira <23406866+MiraMarshall@users.noreply.github.com>
Co-authored-by: Claire Davis <clairepdavis@gmail.com>
Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: AbdulHafeezGalib <77202232+Abdul-Hafeez-Galib@users.noreply.github.com>
Co-authored-by: Alexandru Mariuti <alexandrumariuti@protonmail.com>
Co-authored-by: pdblasi-google <109253501+pdblasi-google@users.noreply.github.com>
Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com>
Co-authored-by: David Gaspar <davidgaspar.dev@gmail.com>
Co-authored-by: John Ryan <ryjohn@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix.bug Needs fix of incorrect copy, code, or visual
Projects
None yet
Development

No branches or pull requests

2 participants