Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why does isFvmInstalled() check for git executable #312

Closed
prasadsunny1 opened this issue Apr 14, 2024 · 2 comments
Closed

why does isFvmInstalled() check for git executable #312

prasadsunny1 opened this issue Apr 14, 2024 · 2 comments

Comments

@prasadsunny1
Copy link

I was exploring how sidekick executes shell commands and found isFvmInstalled check for git, I think its a mistake and it should be checking for fvm instead.

https://github.com/fluttertools/sidekick/blob/356124bea7bc3c9bcd0373f1903a836d2204c569/lib/src/modules/compatibility_checks/compat.utils.dart#L23C2-L29C2

Future<bool> isFvmInstalled() async {
  final fvmRes = await which("git");
  if (fvmRes != null) {
    return true;
  }
  return false;
}
@aguilaair
Copy link
Collaborator

yep! FVM comes included with Sidekick so the check might not even be needed

@charles0122
Copy link
Contributor

@aguilaair We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants