Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flux_job_kvs_namespace(3) and use it in job-exec for guest namespace #2315

Merged
merged 7 commits into from Aug 16, 2019
Merged

Add flux_job_kvs_namespace(3) and use it in job-exec for guest namespace #2315

merged 7 commits into from Aug 16, 2019

Commits on Aug 16, 2019

  1. libjob: add common function for checking buffer args 

    Collect "buffer args" checks into a single function to avoid code
duplication.
    @grondo
    grondo committed Aug 16, 2019
    Copy the full SHA
    6df84f4 View commit details
    Browse the repository at this point in the history

  2. libjob: add flux_job_kvs_namespace(3) 

    Add a function to write the standard guest namespace for jobs into
a buffer, to avoid users hand-coding an expected and possibly changing
guest namespace name in scripts/code/etc.
    @grondo
    grondo committed Aug 16, 2019
    Copy the full SHA
    7e1e245 View commit details
    Browse the repository at this point in the history

  3. test: libjob: test flux_job_kvs_namespace(3) 

    Add simple tests for flux_job_kvs_namespace()
    @grondo
    grondo committed Aug 16, 2019
    Copy the full SHA
    a984ee0 View commit details
    Browse the repository at this point in the history

  4. flux-job: print failing arg in parse_arg_unsigned 

    Improve error usefulness by including the argument that failed
to parse as unsigned in flux-job's parse_arg_unsigned() helper
function.
    @grondo
    grondo committed Aug 16, 2019
    Copy the full SHA
    225e9ea View commit details
    Browse the repository at this point in the history

  5. flux-job: add namespace subcommand 

    Add a subcommand that converts flux job ids to namespace names,
giving users and scripts a standard way to get kvs guest namespace
names for jobs.
    @grondo
    grondo committed Aug 16, 2019
    Copy the full SHA
    4c68a6f View commit details
    Browse the repository at this point in the history

  6. testsuite: test flux-job namespace 

    Add some sanity checks for the flux-job namespace subcommand.
    @grondo
    grondo committed Aug 16, 2019
    Copy the full SHA
    9e7df7a View commit details
    Browse the repository at this point in the history

  7. job-exec: use flux_job_kvs_namespace() to create namespace name 

    Switch to using libjob's flux_job_kvs_namespace() to create job
guest kvs namespace names, instead of using the dothex notation
of a flux_jobid_t.

This puts job namespace name generation in a single place so that
these names do not have to be generated manually anywhere, as
well as allowing the naming convention to be updated in the future
without breaking any existing code.

As a side effect, this fixes a problematic side effect of kvs
namespace names with periods in them, since these names are
used as keys in kvs module stats output.

Fixes flux-framework#2306
    @grondo
    grondo committed Aug 16, 2019
    Copy the full SHA
    f30da5a View commit details
    Browse the repository at this point in the history