Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Respect requirements.yaml in helm operator #1278

Closed
squaremo opened this issue Aug 9, 2018 · 10 comments
Closed

Respect requirements.yaml in helm operator #1278

squaremo opened this issue Aug 9, 2018 · 10 comments

Comments

@squaremo
Copy link
Member

squaremo commented Aug 9, 2018

Charts can come with dependencies: https://docs.helm.sh/developing_charts/#chart-dependencies

I believe the Helm CLI deals with these dependencies -- either downloading the charts from the repository given, or grabbing them from the fileystem before sending to Tiller.

We should come up with a sensible way to let people use the dependency management with the helm operator.

@ahmadiq
Copy link

ahmadiq commented Aug 17, 2018

+1 We're facing this issue as well. We'd like for the chart dependencies in the requirements.yaml to be downloaded automatically. At the moment we're providing a reference to the public chart repository in the requirements.yaml but that doesn't download, and we seem to need to include the chart within our flux release repo.

requirements.yaml snippet:

dependencies:

- name: prometheus
  version: 1.0.19
  repository: https://stakater.github.io/stakater-charts
  alias: prometheus

- name: grafana
  version: 1.0.31
  repository: https://stakater.github.io/stakater-charts  
  alias: grafana

@stephenmoloney
Copy link
Contributor

Is this issue a duplicate of #1131 ?

@ahmadiq
Copy link

ahmadiq commented Aug 20, 2018

Hi @stephenmoloney yes my use case seems to be the same as in #1131
@squaremo can assess from his side as well.

@dbluxo
Copy link

dbluxo commented Sep 5, 2018

+1

@squaremo
Copy link
Member Author

#1131 is for being able to refer to a chart from a Helm repo, in a FluxHelmRelease, and have that installed.
This bug crosses over releasing charts from git and charts from a Helm repo, both of which may have requirements.yaml, though we may do different things with it in each case.

@squaremo
Copy link
Member Author

In the case of charts from git, I think it's reasonable to expect the helm operator to (optionally) get the dependencies before applying. I'm not sure whether it makes more sense to have this as a command-line switch, or specify it per FluxHelmRelease.

@dbluxo
Copy link

dbluxo commented Oct 16, 2018

Why should this be optional? Specified dependencies should be always resolved.

@jasaltvik
Copy link

@dbluxo Sometimes the dependency isn't used. A good example is a chart that depends on some sort of DB, but allow you to use your own. I guess it doesn't hurt always resolving the dependency, even in situations where you do not use it, to avoid complexity in Flux.

@dbluxo
Copy link

dbluxo commented Oct 16, 2018

I understand, good point. So I would prefer that the dependencies will be resolved as default. Having the possibility to turn it off via FluxHelmRelease.

@squaremo
Copy link
Member Author

#1450 added a step to download dependencies before installing a chart; #1382 subsequently included it too, so it's also in the "beta" series release (0.5.0 onward).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants