Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Warn when HelmRelease values are the wrong type #2232

Closed
squaremo opened this issue Jul 9, 2019 · 1 comment
Closed

Warn when HelmRelease values are the wrong type #2232

squaremo opened this issue Jul 9, 2019 · 1 comment

Comments

@squaremo
Copy link
Member

squaremo commented Jul 9, 2019

When interpreting the spec.values part of a HelmRelease, fluxd will silently skip any images with a tag that isn't typed string. That's because they really should be strings, since e.g., 1.10 in YAML will end up as 1.1 if not quoted.

This is surprising if you have not internalised that quirk of YAML, so we should put a warning in the log that the .spec.values is faulty, in those cases.

@kingdonb
Copy link
Member

No further enhancements can land in Flux v1,

Arguably this is a bug, (but not one I think we are likely to fix in Flux v1.)

If there was an implementation presented, I would still consider it for merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants