-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Filter pattern type: strict-semver #2729
Comments
Can you post here an example of a semver filter and a miss-match of 8 charts, Flux uses https://github.com/Masterminds/semver, I'm going to update Flux to the latest version of that package and write a test if you can provide me with the above. |
At first thank you for your support. We already noticed this, the implementation there is also wrong. But i will give you a more detailed explanation:
Pls ask if you need more information on this. |
It appears this issue has been taken into account in the redesigned Flux v2, per linked discussions in the I think after reading the discussion there, they have settled for a particular implementation that is aligned with what Helm itself uses for semver parsing. I am not certain it will behave differently after a brief reading of the code and discussion there. I have a bone to pick with the Someone should be in the position to increment the automation policy for a major version change in the PR where this review is completed, but I am not here to argue this point. I am not certain if this issue is still affecting you, or if it can be considered resolved by Flux v2. Flux v1 is in maintenance mode now, and is not adding any new features unless they are critical. As Flux contrib efforts have been focused on Flux v2, the Flux project has moved to a new repo, fluxcd/flux2 In the interest of reducing the number of open issues not directly related to supporting Flux v1 in maintenance mode, and respecting you may have moved on already, I will go ahead and close out this issue for now. Thanks for using Flux! |
Describe the feature
Actual there exist 3 filter pattern types: glob, regexp and semver. semver is documented to filter for Semantic Versioning, but it isnt. While semver.org describes a valid semver with the X.Y.Z patter, this implementation allows a lot more. So for flux just an integer is seen as a semver. Pls have a look at this: regex101. I would call this a bug..., but as changing this behavior would break things I would go for another filter:
strict-semver
To describe the actual failure that occured:
This integer is detected as a semver and deployed.
Deployments stuck on this tag as a 8 digit integer is > the valid semver releases.
What would the new user story look like?
0. Use
strict-semver
as tag filter.Expected behavior
Because a change/fix of this behavior would break things for others, I would like to have a filter like:
strict-semver
.strict-semver
should filter only valid Semantic Versions.The text was updated successfully, but these errors were encountered: