Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Allow dependsOn to contain a mix of Kustomize/HelmRelease #3520

Closed
dan-j opened this issue Jul 29, 2021 · 3 comments
Closed

Allow dependsOn to contain a mix of Kustomize/HelmRelease #3520

dan-j opened this issue Jul 29, 2021 · 3 comments

Comments

@dan-j
Copy link

dan-j commented Jul 29, 2021

Great project! I'm only a couple of days into learning the Flux ecosystem however I've just tried to create a Kustomization which dependsOn a HelmRelease and it appears that this isn't supported.

I can't find a similar issue so I'm not sure if this has been discussed before, is there any views to supporting this kind of behaviour?

You could introduce a new kind field to dependency.CrossNamespaceDependencyReference, which if not set defaults to the kind of the source resource (which maintains this feature as a non-breaking change), but if is set, will lookup that resource type rather than implying it's the same kind as the source.

Thoughts? I'm always open to making PRs to open source, but interested to see what the maintainers thoughts are, and how complex a change like this might be to make.

@kingdonb
Copy link
Member

There is a discussion in the fluxcd/flux2 repo, this repo is for Flux v1 (which is in maintenance mode)

fluxcd/flux2#730

This has been brought up before. There did not seem to be consensus that what we have done is the only way.

I would take a look through that discussion, for some background

fluxcd/flux2#1599

This one has been more recent, and probably more reflective of the maintainer team's current thoughts about the issue.

@kingdonb
Copy link
Member

(Closing as duplicate, mis-filed.)

@dan-j
Copy link
Author

dan-j commented Jul 29, 2021

Oh! Apologies, I'll check that out 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants