Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for empty gpg key ring path #1913

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Add check for empty gpg key ring path #1913

merged 3 commits into from
Oct 8, 2021

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Oct 8, 2021

This fixes a regression bug introduced by #1854 when the --gpg-key-path flag is not set.

internal/bootstrap/git/gogit/gogit.go Outdated Show resolved Hide resolved
internal/bootstrap/git/gogit/gogit.go Outdated Show resolved Hide resolved
internal/bootstrap/git/gogit/gogit.go Outdated Show resolved Hide resolved
internal/bootstrap/git/gogit/gogit.go Outdated Show resolved Hide resolved
somtochiama and others added 3 commits October 8, 2021 19:19
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco changed the title Add check for empty gpg key path Add check for empty gpg key ring path Oct 8, 2021
@hiddeco hiddeco added area/bootstrap Bootstrap related issues and pull requests bug Something isn't working enhancement New feature or request labels Oct 8, 2021
@stefanprodan stefanprodan merged commit d9414f2 into fluxcd:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants