Allow users to use gpg signing for bootstrap commits #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Thinking about future expansions of this feature, is it possible in Go to detect the user's running GPG agent?
Update: this does not seem to be possible in an easy way with out-of-the-box Go solutions. Your approach, but then with #1854 (comment) taken into account should do for now.
hiddeco
reviewed
Oct 4, 2021
hiddeco
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Thanks a lot for adding tests @somtochiama! This looks good to me, if you squash your commits (and the tests pass), it can be merged. 🥇
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
stefanprodan
added
area/bootstrap
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1774
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com