Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for GCP #4017

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Add e2e tests for GCP #4017

merged 2 commits into from
Jul 14, 2023

Conversation

somtochiama
Copy link
Member

This pull request adds e2e tests for GCP, building on the structure established in #3489 .

@hiddeco hiddeco added the area/testing Testing related issues and pull requests label Jun 30, 2023
darkowlzz
darkowlzz reviewed Jul 4, 2023
View reviewed changes
tests/integration/.env.sample Outdated Show resolved Hide resolved
tests/integration/README.md Outdated Show resolved Hide resolved
tests/integration/README.md Show resolved Hide resolved
tests/integration/suite_test.go Outdated Show resolved Hide resolved
tests/integration/terraform/gcp/main.tf Outdated Show resolved Hide resolved
tests/integration/terraform/gcp/main.tf Outdated Show resolved Hide resolved
tests/integration/gcp_test.go Outdated Show resolved Hide resolved
tests/integration/terraform/gcp/main.tf Show resolved Hide resolved
tests/integration/README.md Show resolved Hide resolved
tests/integration/README.md Outdated Show resolved Hide resolved
darkowlzz
darkowlzz reviewed Jul 10, 2023
View reviewed changes
tests/integration/.env.sample Outdated Show resolved Hide resolved
tests/integration/README.md Outdated Show resolved Hide resolved
tests/integration/gcp_test.go Outdated Show resolved Hide resolved
tests/integration/gcp_test.go Outdated Show resolved Hide resolved
tests/integration/gcp_test.go Outdated Show resolved Hide resolved
tests/integration/suite_test.go Show resolved Hide resolved
tests/integration/terraform/gcp/main.tf Show resolved Hide resolved
tests/integration/terraform/gcp/outputs.tf Outdated Show resolved Hide resolved
tests/integration/terraform/gcp/outputs.tf Outdated Show resolved Hide resolved
tests/integration/terraform/gcp/variables.tf Outdated Show resolved Hide resolved
darkowlzz
darkowlzz reviewed Jul 12, 2023
View reviewed changes
tests/integration/.env.sample Outdated Show resolved Hide resolved
tests/integration/suite_test.go Outdated Show resolved Hide resolved
tests/integration/.env.sample Outdated Show resolved Hide resolved
tests/integration/README.md Show resolved Hide resolved
tests/integration/azure_test.go Outdated Show resolved Hide resolved
tests/integration/README.md Outdated Show resolved Hide resolved
darkowlzz
darkowlzz reviewed Jul 12, 2023
View reviewed changes
tests/integration/notification_test.go Outdated Show resolved Hide resolved
tests/integration/suite_test.go Show resolved Hide resolved
tests/integration/gcp_test.go Outdated Show resolved Hide resolved
@somtochiama somtochiama force-pushed the gcp-e2e branch 2 times, most recently from ea061dc to 7b52d26 Compare July 14, 2023 12:48
@somtochiama
Add terraform files and config for GCP
c8e9a9a 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama
make tests for notifications provider agnostic
59ac514 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
darkowlzz
darkowlzz approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually. Works great.
LGTM!
Thanks.

@darkowlzz darkowlzz merged commit c8e0170 into fluxcd:azure-e2e-refactor Jul 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/testing Testing related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@somtochiama @darkowlzz @hiddeco