Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refactored e2e tests #3489

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Add refactored e2e tests #3489

merged 1 commit into from
Jun 23, 2023

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Jan 16, 2023 •
edited
Loading

This pull request refactors the existing e2e tests so that we could reuse the same structure for testing other cloud providers like GCP and AWS.

Things to note about the new setup:

  • We create the infrastructure on each test run and the terraform uses a local backend. This makes it easier for anyone to run the test locally.
  • The tests for notifications and git commit status still only test Azure. Updating these tests will come as a follow-up to this pull request.
  • For details on how to run the new tests, please take a look at the README.md in tests/integration

@somtochiama somtochiama force-pushed the azure-e2e-main branch 2 times, most recently from 9c2de60 to 2fe7068 Compare January 16, 2023 12:13
@somtochiama somtochiama changed the base branch from main to azure-e2e-refactor January 16, 2023 13:29
darkowlzz
darkowlzz reviewed Jan 24, 2023
View reviewed changes
tests/integration/go.mod Outdated Show resolved Hide resolved
tests/integration/suite_test.go Outdated Show resolved Hide resolved
tests/integration/suite_test.go Outdated Show resolved Hide resolved
darkowlzz
darkowlzz reviewed Jan 25, 2023
View reviewed changes
tests/integration/terraform/azure/aks.tf Outdated Show resolved Hide resolved
tests/integration/suite_test.go Outdated Show resolved Hide resolved
darkowlzz
darkowlzz reviewed Jan 30, 2023
View reviewed changes
tests/integration/azure_specific_test.go Outdated Show resolved Hide resolved
tests/integration/terraform/azure/event-hub.tf Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
darkowlzz
darkowlzz reviewed Mar 21, 2023
View reviewed changes
.github/workflows/e2e-azure.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-azure.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-azure.yaml Outdated Show resolved Hide resolved
tests/.gitignore Outdated Show resolved Hide resolved
tests/integration/Makefile Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
tests/integration/sops_encryption_test.go Outdated Show resolved Hide resolved
tests/integration/flux_test.go Show resolved Hide resolved
tests/integration/terraform/azure/azuredevops.tf Outdated Show resolved Hide resolved
@somtochiama somtochiama changed the base branch from azure-e2e-refactor to main March 24, 2023 15:52
@somtochiama somtochiama changed the base branch from main to azure-e2e-refactor March 24, 2023 15:53
darkowlzz
darkowlzz reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some more comments.
Let's pass all the terraform config via terraform fmt.

tests/integration/terraform/azure/variables.tf Outdated Show resolved Hide resolved
tests/integration/.env.sample Show resolved Hide resolved
tests/integration/Makefile Outdated Show resolved Hide resolved
tests/integration/README.md Outdated Show resolved Hide resolved
tests/integration/README.md Outdated Show resolved Hide resolved
tests/integration/util_test.go Outdated Show resolved Hide resolved
tests/integration/terraform/azure/main.tf Outdated Show resolved Hide resolved
@somtochiama somtochiama changed the base branch from azure-e2e-refactor to main June 5, 2023 12:53
@somtochiama somtochiama changed the base branch from main to azure-e2e-refactor June 5, 2023 12:53
@somtochiama somtochiama changed the base branch from azure-e2e-refactor to main June 16, 2023 09:47
@somtochiama somtochiama changed the base branch from main to azure-e2e-refactor June 16, 2023 09:47
@somtochiama somtochiama changed the title Move refactored e2e tests to a new dir Add refactored e2e tests Jun 23, 2023
@somtochiama
Add refactored e2e tests
9b3103b 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@somtochiama somtochiama marked this pull request as ready for review June 23, 2023 18:53
@somtochiama somtochiama changed the base branch from azure-e2e-refactor to main June 23, 2023 18:59
@somtochiama somtochiama changed the base branch from main to azure-e2e-refactor June 23, 2023 18:59
darkowlzz
darkowlzz approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing everything and doing all the valuable work on this.
I've tested it myself and it works beautifully.
LGTM!

NOTE: This is against the branch azure-e2e-refactor. These changes will be further tested in CI before merging to the main branch.

@darkowlzz darkowlzz merged commit 2bbd7b5 into fluxcd:azure-e2e-refactor Jun 23, 2023
@somtochiama somtochiama mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@somtochiama @darkowlzz