Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to send events without metadata #119

Closed
hiddeco opened this issue Jul 7, 2021 · 0 comments · Fixed by #123
Closed

Make it easier to send events without metadata #119

hiddeco opened this issue Jul 7, 2021 · 0 comments · Fixed by #123
Labels
area/runtime Controller runtime related issues and pull requests

Comments

@hiddeco
Copy link
Member

hiddeco commented Jul 7, 2021

fluxcd/source-controller@26ebbe5 mentions:

  Passing `nil` every time there isn't any metadata for an event quickly
  becomes cumbersome; we should look into an `EventWithMetadata` and/or
  `EventfWithMetadata`, or some other way to _optionally_ provide
  metadata without annoying the consumer.
@hiddeco hiddeco mentioned this issue Jul 8, 2021
Merged
@hiddeco hiddeco added the area/runtime Controller runtime related issues and pull requests label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/runtime Controller runtime related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make it easier to send events without metadata fluxcd/pkg
1 participant
@hiddeco