Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking second time on garbage can while not having approved first time #86

Closed
lvanvugt opened this issue Jan 30, 2021 · 3 comments
Closed

Clicking second time on garbage can while not having approved first time #86

lvanvugt opened this issue Jan 30, 2021 · 3 comments
Assignees
@lvanvugt
Labels
bug Something isn't working version A To be picked up right away
Milestone
beta release

Comments

@lvanvugt
Copy link
Contributor

lvanvugt commented Jan 30, 2021 •
edited
Loading

Clicking second time on garbage can, leaves Given/Then in ATTD.TestScriptor page. While ...

  • not having approved first time, and
  • approving only after second click on garbage can, which
  • will remove .al comment, function call and function definition, but .

To Reproduce
Steps to reproduce the behavior execute the following test scenarios

No. Feature Scenario
0089 Removing Given Remove Given clicking twice
0090 Removing Given Remove Given clicking twice step 2
0091 Removing Given Remove Given clicking twice step 3
0092 Removing Then Remove Then clicking twice
0093 Removing Then Remove Then clicking twice step 2
0094 Removing Then Remove Then clicking twice step 3

in atdd-test-scenarios-and-results.xlsx

Result
The Given being removed (i.e. "Valid Given" in test scenarios) is not removed from Given section in ATTD.TestScriptor page.

Expected result
The Given being removed (i.e. "Valid Given" in test scenarios) is removed from Given section in ATTD.TestScriptor page.

Belonging to #28 and similar to #88.
@lvanvugt lvanvugt added bug Something isn't working version A To be picked up right away labels Jan 30, 2021
@lvanvugt lvanvugt mentioned this issue Jan 30, 2021
Closed
@lvanvugt
Copy link
Contributor Author

@martonsagi, can this be fixed by catching any additional click on the control within a short time?

@lvanvugt lvanvugt mentioned this issue Jan 31, 2021
Closed
@lvanvugt lvanvugt added this to the beta release milestone Jan 31, 2021
martonsagi added a commit that referenced this issue Feb 8, 2021
@martonsagi
#86, #88: new loader screen, #95: fix empty list
d6b4386
@martonsagi
Copy link
Collaborator

Added a loader that blocks users from clicking twice when a backend interaction is initiated.

ATDD_Loader

martonsagi added a commit that referenced this issue Feb 8, 2021
@martonsagi
#86, #88: hide toolbar behind overlay
e23f5a4
@lvanvugt lvanvugt assigned lvanvugt and unassigned martonsagi Feb 9, 2021
@lvanvugt
Copy link
Contributor Author

lvanvugt commented Feb 9, 2021

Tested and OK.

@lvanvugt lvanvugt closed this as completed Feb 9, 2021
@lvanvugt lvanvugt mentioned this issue Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvanvugt lvanvugt

Labels
bug Something isn't working version A To be picked up right away
Projects
None yet
Milestone
beta release
Development

No branches or pull requests
3 participants
@martonsagi @lvanvugt @DavidFeldhoff