Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Case: Removing Given-When-Then #28

Closed
lvanvugt opened this issue Jun 21, 2020 · 4 comments
Closed

Use Case: Removing Given-When-Then #28

lvanvugt opened this issue Jun 21, 2020 · 4 comments
Assignees
@lvanvugt
Labels
version A To be picked up right away
Milestone
beta release

Comments

@lvanvugt
Copy link
Contributor

lvanvugt commented Jun 21, 2020 •
edited
Loading

The following flowchart shows the use case:

Use Case (#28) - Removing Given-When-Then

Exceptions

Settings

  • Make setting possible that user can disable the confirm on removing helper function with two flavors
    1. Do not show and do not remove (this scenario is not (yet) in flowchart)
    2. Do not show, but do remove
lvanvugt pushed a commit that referenced this issue Jun 21, 2020
@fluxxusnl
Upload of flowchart. #28
5d6bca9
@lvanvugt lvanvugt added enhancement New feature or request version A To be picked up right away labels Jun 21, 2020
@lvanvugt lvanvugt mentioned this issue Jul 20, 2020
Closed
@DavidFeldhoff
Copy link
Collaborator

I pushed an update on this. The settings part is currently missing, so I've still something to do here.
@martonsagi can you improve the UI-behaviour on deletion as currently the UI-element is deleted before the user confirms that he wants to delete that?

@lvanvugt lvanvugt mentioned this issue Jul 29, 2020
Closed
lvanvugt pushed a commit that referenced this issue Aug 18, 2020
@fluxxusnl
test scenarios and result for #27, #28 and #30
74cdd26
lvanvugt pushed a commit that referenced this issue Sep 24, 2020
@fluxxusnl
Added new tests and rerun all #27 #28 #30 #38 #39
759eb78
@lvanvugt lvanvugt mentioned this issue Sep 25, 2020
Closed
@DavidFeldhoff
Copy link
Collaborator

fixed here
4bd3fbf#diff-f267418653192133529f152c33dd6450R145
Luc, I'll assign it to you for testing or closing. If you find some bugs I would suggest to create new issues for that

This was referenced Oct 6, 2020
Closed
Closed
Closed
Closed
@lvanvugt
Copy link
Contributor Author

lvanvugt commented Oct 6, 2020

Luc, I'll assign it to you for testing or closing. If you find some bugs I would suggest to create new issues for that

See attached bugs.

DavidFeldhoff added a commit that referenced this issue Oct 28, 2020
@DavidFeldhoff
Add removalMode Settings #39, #28
00fb700
@lvanvugt lvanvugt removed the enhancement New feature or request label Oct 28, 2020
DavidFeldhoff added a commit that referenced this issue Oct 28, 2020
@DavidFeldhoff
Fix wrong default-setting #39, #28
1f2cf83
@lvanvugt
Copy link
Contributor Author

Tested all existing scenarios and OK

lvanvugt added a commit that referenced this issue Jan 30, 2021
@lvanvugt
Retested #28 and OK
65122d6
@lvanvugt lvanvugt added this to the beta release milestone Jan 31, 2021
@lvanvugt lvanvugt mentioned this issue Feb 1, 2021
Closed
@lvanvugt lvanvugt mentioned this issue Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvanvugt lvanvugt

Labels
version A To be picked up right away
Projects
None yet
Milestone
beta release
Development

No branches or pull requests
2 participants
@lvanvugt @DavidFeldhoff