Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Case: Removing Scenario #39

Closed
lvanvugt opened this issue Jul 29, 2020 · 14 comments
Closed

Use Case: Removing Scenario #39

lvanvugt opened this issue Jul 29, 2020 · 14 comments
Assignees
@lvanvugt
Labels
version A To be picked up right away
Milestone
beta release

Comments

@lvanvugt
Copy link
Contributor

lvanvugt commented Jul 29, 2020 •
edited
Loading

The following flowchart shows the use case:

Use Case (#39) - Removing Scenario

Exceptions

Settings

  • Make setting possible that user can disable the confirm on removing helper function with two flavors (see Use Case: Removing Given-When-Then #28)
    1. Do not show and do not remove (this scenario is not (yet) in flowchart)
    2. Do not show, but do remove
  • And similar setting regarding disabling confirm on removing test function

Notes

  • The garbage can icon to remove a scenario has been replaced by a red '- Scenario' button

Test Scenarios

No. Feature Scenario
0056 Removing Scenario Removing Scenario
0057 Removing Scenario Removing Scenario step 2a
0058 Removing Scenario Removing Scenario step 3a
0059 Removing Scenario Removing Scenario step 2b
0060 Removing Scenario Removing Scenario step 3b
0068 Removing Scenario Removing Scenario with Initialize
0069 Removing Scenario Removing Scenario with UI Handler
0070 Removing Scenario Removing Scenario with UI Handler 2
0071 Removing Scenario Removal Mode "No confirmation, but removal"
0072 Removing Scenario Removal Mode "No confirmation & no removal"

in atdd-test-scenarios-and-results.xlsx
lvanvugt pushed a commit that referenced this issue Jul 29, 2020
@fluxxusnl
Added "Removing Scenario" flowchart #39
ed6e726
@DavidFeldhoff DavidFeldhoff added the version B Next to be picked up (but needs probably some detailing) label Sep 7, 2020
@DavidFeldhoff
Copy link
Collaborator

If the Scenario has handler functions these should be deleted (after a confirmation of the user) as well, I guess? I'll implement it like this at first.

@lvanvugt
Copy link
Contributor Author

Agree.

@DavidFeldhoff DavidFeldhoff added version A To be picked up right away and removed version B Next to be picked up (but needs probably some detailing) labels Sep 21, 2020
@DavidFeldhoff DavidFeldhoff self-assigned this Sep 21, 2020
@lvanvugt
Copy link
Contributor Author

@DavidFeldhoff no commits related to this issue?

@DavidFeldhoff
Copy link
Collaborator

Sorry, haven't linked that appropriately. Will fix that later

lvanvugt pushed a commit that referenced this issue Sep 24, 2020
@fluxxusnl
Second feature/scenario added #39
f2a57c5
lvanvugt pushed a commit that referenced this issue Sep 24, 2020
@fluxxusnl
Added new tests and rerun all #27 #28 #30 #38 #39
759eb78
This was referenced Sep 25, 2020
Closed
Closed
@DavidFeldhoff
Copy link
Collaborator

fixed in commit
4bd3fbf

@DavidFeldhoff
Copy link
Collaborator

..Forgot the removal of HandlerFunctions - I hope I can add that this evening

DavidFeldhoff added a commit that referenced this issue Oct 2, 2020
@DavidFeldhoff
add dependency to al-codeactios; delete handler functions #39
96d30d5
@DavidFeldhoff
Copy link
Collaborator

hm.. already implemented that as well in the commit above, but I'm using there the gotodefinition provider of my al-codeactions there, so I added that as dependency.
@lvanvugt The stage is yours for testing :)

@lvanvugt
Copy link
Contributor Author

lvanvugt commented Oct 5, 2020

@DavidFeldhoff tested and OK

@lvanvugt lvanvugt closed this as completed Oct 5, 2020
lvanvugt pushed a commit that referenced this issue Oct 5, 2020
@fluxxusnl
Added new test scenario 0064 and update test-project #39
8e8a0cb
lvanvugt pushed a commit that referenced this issue Oct 5, 2020
@fluxxusnl
Update |Fetaure description on new test codeunit #39
ae070ae
lvanvugt pushed a commit that referenced this issue Oct 5, 2020
@fluxxusnl
#39 Tested and OK
e60156e
@lvanvugt
Copy link
Contributor Author

lvanvugt commented Oct 5, 2020

@DavidFeldhoff: reopened as the settings have not been added yet.

@lvanvugt lvanvugt reopened this Oct 5, 2020
@lvanvugt lvanvugt assigned DavidFeldhoff and unassigned lvanvugt Oct 5, 2020
DavidFeldhoff added a commit that referenced this issue Oct 24, 2020
@DavidFeldhoff
Delete helper function also if both calls are in same scenario
ab559ce 
#39
DavidFeldhoff added a commit that referenced this issue Oct 24, 2020
@DavidFeldhoff
Delete helper function also if both calls are in same scenario
ca88548 
#39
DavidFeldhoff added a commit that referenced this issue Oct 28, 2020
@DavidFeldhoff
Add removalMode Settings #39, #28
00fb700
DavidFeldhoff added a commit that referenced this issue Oct 28, 2020
@DavidFeldhoff
Fix wrong default-setting #39, #28
1f2cf83
@DavidFeldhoff
Copy link
Collaborator

Hi Luc, feel free to test this one, it's ready and works as well with the settings.

lvanvugt pushed a commit that referenced this issue Oct 28, 2020
@fluxxusnl
Added and updated .al objects #39
1bbe461
@lvanvugt
Copy link
Contributor Author

Tested and added some extra scenarios -> OK

lvanvugt pushed a commit that referenced this issue Oct 28, 2020
@fluxxusnl
tested #39 and #67 and OK
fbdb5d5
@lvanvugt lvanvugt mentioned this issue Nov 21, 2020
Closed
@lvanvugt
Copy link
Contributor Author

Reopened due to #80.

@lvanvugt lvanvugt reopened this Nov 21, 2020
@lvanvugt
Copy link
Contributor Author

Closed as #80 cannot be reproduced.

lvanvugt added a commit that referenced this issue Jan 30, 2021
@lvanvugt
Retested #39 and OK
5144a77
@lvanvugt lvanvugt mentioned this issue Jan 30, 2021
Closed
@lvanvugt lvanvugt reopened this Jan 30, 2021
@lvanvugt lvanvugt mentioned this issue Jan 31, 2021
Closed
@lvanvugt lvanvugt added this to the beta release milestone Jan 31, 2021
lvanvugt added a commit that referenced this issue Jan 31, 2021
@lvanvugt
Additonal issue #88 testing #39
26f0178
@lvanvugt
Copy link
Contributor Author

#86 and #88 fixed, so closed

@lvanvugt lvanvugt mentioned this issue Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvanvugt lvanvugt

Labels
version A To be picked up right away
Projects
None yet
Milestone
beta release
Development

No branches or pull requests
2 participants
@lvanvugt @DavidFeldhoff