Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gems are rebuilt on gemdir input change #17

Closed
samueldr opened this issue Feb 22, 2022 · 3 comments
Closed

Gems are rebuilt on gemdir input change #17

samueldr opened this issue Feb 22, 2022 · 3 comments

Comments

@samueldr
Copy link
Collaborator

samueldr commented Feb 22, 2022

See:

Since the gemdir is the src dir, any change will also cause a minor rebuild of the gems layer. Note that this only "re-assembles" the gem directory, no gems are being rebuilt. The actual cost in build time is negligible, but still present.

The solution listed here might not be correct, as it wouldn't include local directories used as gems. Though the general approach would be correct, e.g. use strictly only the inputs required for gems. Not sure how to best approach this.

@samueldr
Copy link
Collaborator Author

samueldr commented Feb 22, 2022

Oh, though it would make a needless layer upload for the gems layer. This is something the CAS (content-adressed store) would help solve, but this is not a solution for now.

@samueldr
Copy link
Collaborator Author

Discussed quickly, we will work under the assumption that no local gems are present, so it's fine to only work on Gemfile+Gemfile.lock

@jsierles
Copy link
Contributor

jsierles commented Mar 9, 2022

Fixed in fly-apps/nix-base#3

@jsierles jsierles closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants