Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): add flipped UV map for right main gear wheel texture #6931

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

bouveng
Copy link
Member

@bouveng bouveng commented Mar 17, 2022

Summary of Changes

This PR flips the UV for the right main gear wheel texture, so it is not mirrored anymore.
This is an impl. of @Grinde81 's work.

Screenshots (if necessary)

BEFORE

Microsoft Flight Simulator 2022-03-17 23_11_06

Note mirrored texture on right main landing gear wheel

AFTER

Microsoft Flight Simulator 2022-03-17 23_22_06b

Texture appearing correct on right main landing gear wheel

Discord username (if different from GitHub): @bouveng

Testing instructions

Spawn with default A32NX livery, or any other livery with text on the main wheels.
Observe no mirroring.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@bouveng bouveng added Texture A texture is wrong somewhere/a texture is missing (should be added) 3D Model 3D model is wrong/something is missing labels Mar 17, 2022
@bouveng bouveng requested a review from tracernz March 17, 2022 22:37
@bouveng bouveng self-assigned this Mar 17, 2022
@ShadowFrost3
Copy link

ShadowFrost3 commented Mar 18, 2022

Quality Assurance Tester Report

Object of testing: #6931
Tier of Testing:1
Date: 18/03/2022

Testing Process: Look at tires
Make sure tires are on properly
???
profit
???
look at the tires again
the tires aren't on properly
???
losses

Redownload
look at tires
tires are on properly
???
profit

Negatives: They don't look the same as in the supplied reference -- Livery dependent
Testing Results: Passed

@bouveng bouveng merged commit f633ad1 into flybywiresim:master Mar 18, 2022
@bouveng bouveng deleted the fix-wheel-uv branch March 19, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D Model 3D model is wrong/something is missing Texture A texture is wrong somewhere/a texture is missing (should be added)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants