-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Cpp WASM Lightweight Framework #7711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankkopp
added
Project
Anything that is related to the development and organization of the project, not an ingame issue.
Not Ready For Review
Still draft but needs a GitHub build
labels
Jan 14, 2023
frankkopp
force-pushed
the
cpp-wasm-framework
branch
4 times, most recently
from
January 22, 2023 22:19
d0971ff
to
4ef7b32
Compare
frankkopp
force-pushed
the
cpp-wasm-framework
branch
4 times, most recently
from
January 28, 2023 22:09
2ad0886
to
2a771a6
Compare
frankkopp
force-pushed
the
cpp-wasm-framework
branch
3 times, most recently
from
February 5, 2023 11:30
1592933
to
6df36cb
Compare
frankkopp
force-pushed
the
cpp-wasm-framework
branch
4 times, most recently
from
February 19, 2023 22:16
599bd16
to
91b9637
Compare
frankkopp
force-pushed
the
cpp-wasm-framework
branch
2 times, most recently
from
February 26, 2023 21:58
ab73a81
to
668e0e4
Compare
frankkopp
force-pushed
the
cpp-wasm-framework
branch
2 times, most recently
from
March 5, 2023 18:30
959fc99
to
4c8a277
Compare
frankkopp
force-pushed
the
cpp-wasm-framework
branch
from
January 4, 2024 20:36
9a2767a
to
9002b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Project
Anything that is related to the development and organization of the project, not an ingame issue.
QA Passed
QA Ready to Test
QA Tier 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR covers three major topics:
Cpp WASM Framework MVP v0.1:
See README.md
Potential future enhancements - out of scope for this PR
Additional improvements to Lighting Presets:
Presets are now loaded gradually so that knobs are actually turn to the correct position.
Previously when a knob has been turn to far in one step the sim's animation wanted to turn the knob in the wrong direction
and became stuck on either 0 or 100 and therefore out of sync of the actual value.
https://user-images.githubusercontent.com/16833201/224556441-95f85c5e-3fc2-4f21-9d19-9adab80d79ce.mp4
Split of former flyPad backend into common, a32nx and a380x specific parts
Aircraft specific parts are minimal now so that adaption to A380X only requires specific aspect.
A380X adaption are not yet done as mostly the aircraft is not ready for them yet (presets). Pushback should already work well.
Discord username (if different from GitHub): Cdr_Maverick#6475
Supporters:
saschl#9432, Sven [de en]# 3752, tracernz#3313
Testing instructions
Test the flyPad related backend features:
Otherwise there should be no difference for end users.
For Devs: Use the framework if anything needs a Cpp implementation - this is the best testing. As long as the existing functionality (former flyPad backend) works these test can be done while developing new Cpp modules.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.